Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update tables and PyYaml versions for python > 3.8 #2085

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Conversation

sylvlecl
Copy link
Member

@sylvlecl sylvlecl commented Jul 9, 2024

Description
When working in python > 3.8 environment, a few dependencies are not available.

This PR allows to work with python >= 3.9 by having a conditional versioning for:

  • tables
  • pyyaml

For python 3.8, versions are unchanged.

@sylvlecl sylvlecl changed the title Tables and PyYaml versions for python > 3.8 build: Update tables and PyYaml versions for python > 3.8 Jul 9, 2024
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we could do such a thing inside requirements, I thought we add to create specific files for each version, nice 😄

Shouldn't we also update the github workflow main.yaml to run it with different python versions ?

@sylvlecl
Copy link
Member Author

I didn't know we could do such a thing inside requirements, I thought we add to create specific files for each version, nice 😄

Shouldn't we also update the github workflow main.yaml to run it with different python versions ?

Indeed it would be intesting to run our tests with other python versions.
However the full matrix of [OS*python versions] will take too long to execute for each push.

What we could do is:

  • keeping only one python version for PR workflows
  • adding other python versions for merges on develop, or for a nightly workflow

@sylvlecl sylvlecl merged commit b4fec58 into dev Jul 12, 2024
5 of 7 checks passed
@sylvlecl sylvlecl deleted the fix/python3.10 branch July 12, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants