Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raw): add arrow support in backend #2083

Draft
wants to merge 27 commits into
base: dev
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
02c8851
first draft
MartinBelthle Jul 5, 2024
b91ae95
remove useless import
MartinBelthle Jul 5, 2024
0202d5d
fix little issue
MartinBelthle Jul 5, 2024
f382780
little fix
MartinBelthle Jul 5, 2024
40c22cf
make json a default value
MartinBelthle Jul 5, 2024
6f0824e
fix some tests
MartinBelthle Jul 5, 2024
3fcb748
fix last tests
MartinBelthle Jul 8, 2024
3a3308a
add pyarrow to requirements
MartinBelthle Jul 8, 2024
2cb0d7e
last change
MartinBelthle Jul 8, 2024
6d411cd
remove useless import
MartinBelthle Jul 8, 2024
e151750
add tests
MartinBelthle Jul 9, 2024
529de98
add arrow support in put raw
MartinBelthle Jul 9, 2024
6452e54
resolve comments
MartinBelthle Jul 10, 2024
f358549
change doc
MartinBelthle Jul 10, 2024
cb7a788
resolve some issues
MartinBelthle Jul 11, 2024
f5a4623
fix another test
MartinBelthle Jul 11, 2024
9ac959f
resolve last test
MartinBelthle Jul 11, 2024
51446d2
resolve conflicts with dev
MartinBelthle Jul 19, 2024
f496108
rebase with dev
MartinBelthle Jul 26, 2024
e7b7703
resolve conflicts
MartinBelthle Jul 26, 2024
beb23fc
resolve issue with dev
MartinBelthle Jul 26, 2024
8311d89
fix tets
MartinBelthle Jul 26, 2024
0a7ccf3
fix lint
MartinBelthle Jul 26, 2024
fa505f5
Merge branch 'dev' into add-arrow-support-in-backend
MartinBelthle Jul 30, 2024
4a5732d
Merge branch 'dev' into add-arrow-support-in-backend
MartinBelthle Aug 7, 2024
123419e
Merge branch 'dev' into add-arrow-support-in-backend
MartinBelthle Aug 19, 2024
59f8beb
Merge branch 'dev' into add-arrow-support-in-backend
MartinBelthle Aug 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
MartinBelthle committed Jul 26, 2024
commit 0a7ccf3bdcbac4cd67e306f50ab4a0848e6ef1b2
Original file line number Diff line number Diff line change
@@ -133,7 +133,7 @@ def save(self, data: t.Union[str, bytes, S], url: t.Optional[t.List[str]] = None
self._assert_not_in_zipped_file()
self._assert_url_end(url)

if isinstance(data, str) and self.context.resolver.resolve(data, format='json'):
if isinstance(data, str) and self.context.resolver.resolve(data, format="json"):
self.get_link_path().write_text(data)
if self.config.path.exists():
self.config.path.unlink()

Unchanged files with check annotations Beta

);
};
const onChange = async (currentName: string) => {

Check warning on line 28 in webapp/src/components/App/Data/DataPropsView.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
if (currentName !== "") {
const f = filter(currentName);
setFilteredDatas(f);
setOpenModal(true);
};
const handleDelete = async (id: string) => {

Check warning on line 61 in webapp/src/components/App/Data/index.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
setIdForDeletion(id);
setOpenConfirmationModal(true);
};
}
};
const onMatrixClick = async (id: string) => {

Check warning on line 100 in webapp/src/components/App/Data/index.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
if (selectedItem) {
const tmp = dataList.find((o) => o.id === selectedItem);
if (tmp) {
}
};
const handleChange = async (e: React.ChangeEvent<HTMLInputElement>) => {

Check warning on line 30 in webapp/src/components/App/Singlestudy/Commands/Edition/DraggableCommands/CommandImportButton.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
e.preventDefault();
const reader = new FileReader();
reader.onload = async (ev: ProgressEvent<FileReader>) => {

Check warning on line 33 in webapp/src/components/App/Singlestudy/Commands/Edition/DraggableCommands/CommandImportButton.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
try {
if (ev.target) {
const text = ev.target.result;
}
};
const onDelete = async (index: number) => {

Check warning on line 121 in webapp/src/components/App/Singlestudy/Commands/Edition/index.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
setOpenDeleteCommandDialog(index);
};
import DigestDialog from "../../../../../common/dialogs/DigestDialog";
import type { EmptyObject } from "../../../../../../utils/tsUtils";
export const ColorStatus = {

Check warning on line 36 in webapp/src/components/App/Singlestudy/HomeView/InformationView/LauncherHistory/JobStepper.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Fast refresh only works when a file only exports components. Use a new file to share constants or functions between components
running: "warning.main",
pending: "grey.400",
success: "success.main",
const buildTree = async (
node: StudyTree,
childrenTree: VariantTree,
): Promise<void> => {

Check warning on line 55 in webapp/src/components/App/Singlestudy/HomeView/StudyTreeView/utils.ts

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
if ((childrenTree.children || []).length === 0) {
node.drawOptions.depth = 1;
node.drawOptions.nbAllChildrens = 0;
const handleSubmit = async (
data: SubmitHandlerPlus<typeof defaultValues>,
) => {

Check warning on line 42 in webapp/src/components/App/Singlestudy/UpgradeDialog.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
return upgradeStudy(study.id, data.values.version).then(onClose);
};
const handleSubmit = async (
data: SubmitHandlerPlus<AdequacyPatchFormFields>,
) => {

Check warning on line 25 in webapp/src/components/App/Singlestudy/explore/Configuration/AdequacyPatch/index.tsx

GitHub Actions / npm-test (ubuntu-20.04)

Async arrow function has no 'await' expression
return setAdequacyPatchFormFields(study.id, data.dirtyValues);
};