feat(bc): avoid unnecessary creation of RHS matrices for binding constraints #2077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
changed the title
laurent-laporte-pro
changed the title
laurent-laporte-pro
changed the title
laurent-laporte-pro
added
enhancement
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
88c1ac2 to
7a2a55b
Compare
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
2 times, most recently
from
3c8a2f0 to
d122d65
Compare
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
f3b5f93 to
c3db377
Compare
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
c3db377 to
1286f5b
Compare
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
1286f5b to
b9e9bd7
Compare
MartinBelthle
requested changes
Jul 12, 2024
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
sylvlecl
requested changes
Jul 17, 2024
There was a problem hiding this comment.
I think we need to change slightly the implementation:
the level of abstraction in the command is not appropriate, it should manipulate nodes and not paths. Manipulation of paths should be hidden inside the nodes as much as possible.
We need to add copy and move operations to the nodes in order to implement this.
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
2 times, most recently
from
1a487dc to
a01cedd
Compare
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
MartinBelthle
requested changes
Jul 23, 2024
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/create_binding_constraint.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Outdated
Show resolved
Hide resolved
MartinBelthle
requested changes
Jul 23, 2024
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
d6ae88a to
e41786e
Compare
sylvlecl
reviewed
Jul 24, 2024
antarest/study/storage/variantstudy/model/command/update_binding_constraint.py
Show resolved
Hide resolved
sylvlecl
reviewed
Jul 24, 2024
…eation and updating
…eation and updating
…tributes_coherence`
… methods of `LazyNode`
mabw-rte
force-pushed
the
feature/1790-bc-bounds-matrices
branch
from
2582a95 to
5cafd86
Compare
sylvlecl
previously approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
We create many matrices, meanwhile some them are useless
Issue:
Over consumption of disk space
Solution:
New paradigm to avoid creating useless matrices