-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(commands): add command ID in variant generation job results #1989
Merged
laurent-laporte-pro
merged 10 commits into
dev
from
feature/add-cmd-id-in-variant-geanaration-outputs
Apr 9, 2024
Merged
feat(commands): add command ID in variant generation job results #1989
laurent-laporte-pro
merged 10 commits into
dev
from
feature/add-cmd-id-in-variant-geanaration-outputs
Apr 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
force-pushed
the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
from
March 26, 2024 17:23
c0b35f7
to
3ce27f6
Compare
laurent-laporte-pro
changed the title
feat(commands): add command ID in variant geanaration outputs
feat(commands): add command ID in variant generation outputs
Mar 26, 2024
laurent-laporte-pro
force-pushed
the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
2 times, most recently
from
March 30, 2024 06:50
c9009f0
to
1428727
Compare
laurent-laporte-pro
force-pushed
the
dev
branch
from
March 30, 2024 06:57
40b806c
to
9e971f4
Compare
laurent-laporte-pro
changed the title
feat(commands): add command ID in variant generation outputs
feat(commands): add command ID in variant generation logs
Mar 30, 2024
laurent-laporte-pro
force-pushed
the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
from
March 30, 2024 09:57
1428727
to
122a525
Compare
laurent-laporte-pro
changed the title
feat(commands): add command ID in variant generation logs
feat(commands): add command ID in variant generation job results
Mar 30, 2024
WARNING |
Actually, this is a change requested by the Script R team. |
Oh okay nice then 😄 |
hdinia
reviewed
Apr 5, 2024
…', 'status' and 'msg'
laurent-laporte-pro
force-pushed
the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
from
April 8, 2024 17:50
0b355be
to
4a9c0e2
Compare
laurent-laporte-pro
force-pushed
the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
from
April 8, 2024 18:06
da8a640
to
d8b55ef
Compare
MartinBelthle
approved these changes
Apr 9, 2024
laurent-laporte-pro
deleted the
feature/add-cmd-id-in-variant-geanaration-outputs
branch
April 9, 2024 07:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L'objectif de cette PR est de modifier le processus de génération des variants afin d'inclure l'identifiant des commandes dans les résultats du Job.
Actuellement, lorsqu'un snapshot d'une variante d'étude est généré, une tâche de génération asynchrone est utilisée. À la fin de cette génération, le résultat de la tâche est analysé pour obtenir un message utilisateur, le statut de la tâche (réussite ou échec), ainsi qu'un détail au format JSON, indiquant la liste des commandes appliquées lors de la génération du variant.
Voici un exemple de génération de variant qui a nécessité d'appliquer plusieurs commandes :
Le détail est une liste de triplet (
name
,status
,msg
) qui renseigne sur le nom et le statut de chaque commande mais ne donne aucune information concernant l'ID de la commande appliquée. Connaître l'identifiant de chaque commande appliquée permettrait de faciliter le diagnostique et la correction des variants en cas d'erreur : la dernière commande en erreur pourrait être supprimée plus facilement.La proposition consiste à remplacer ce format actuel par un objet JSON plus structuré, contenant les attributs suivants :
id
: identifiant de la commande (UUID),name
: nom de la commande,status
: statut de la commande (true
oufalse
),msg
: message de la génération de la commande ou message d'erreur (si le statut estfalse
).Exemple de résultat attendu :
ATTENTION : Il est important de noter que le support de l'ancien format de détails (
name
,status
,msg
) sera maintenu pour les variantes déjà générées, afin de garantir la compatibilité avec les données existantes. Aucune migration de données ne sera effectuée dans cette PR.