fix(study-search): correct the SQL query used for pagination #1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
force-pushed
the
bugfix/study-search-pagination-v2
branch
from
62a5908 to
969d7cd
Compare
laurent-laporte-pro
force-pushed
the
bugfix/study-search-pagination-v2
branch
from
969d7cd to
af62c83
Compare
laurent-laporte-pro
force-pushed
the
bugfix/study-search-pagination-v2
branch
from
af62c83 to
88f9a09
Compare
mabw-rte
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Pagination Issue in
_search_studiesMethodIn this PR, I've fixed a bug in the
_search_studiesmethod in therepository.pyfile. The bug was causing issues with pagination becausejoinedloadwas being used unnecessarily when we already had a classicjoinin our query.By avoiding the use of
joinedload, the pagination issue has been resolved. Now, the SQL query is correctly generated by SqlAlchemy in the case of pagination (using LIMIT and OFFSET).I've also updated the unit tests in the
test_repository.pyfile to ensure that the pagination works as expected.