Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(outputs): build outputs config even when using cache #1958

Merged
merged 3 commits into from
Mar 25, 2024
Merged

fix(outputs): build outputs config even when using cache #1958

merged 3 commits into from
Mar 25, 2024

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Feb 29, 2024 •
edited
Loading

Resolves [ANT-1314]

@MartinBelthle MartinBelthle linked an issue Feb 29, 2024 that may be closed by this pull request
[AntaresWeb] Output disappeared #1936
Closed
@MartinBelthle MartinBelthle self-assigned this Feb 29, 2024
@MartinBelthle
Copy link
Contributor Author

MartinBelthle commented Mar 1, 2024 •
edited
Loading

The test is good and the code works but it's more a workaround than a solution.
Because, i did not investigate why we lose the information at some point :/

@MartinBelthle MartinBelthle changed the title fix(outputs): build outputs config even when using cache fix(outputs): [ANT-1314] build outputs config even when using cache Mar 5, 2024
@MartinBelthle MartinBelthle force-pushed the fix/output-disappeared branch from 040fd10 to 7dc1ba1 Compare March 5, 2024 09:20
@MartinBelthle MartinBelthle changed the title fix(outputs): [ANT-1314] build outputs config even when using cache fix(outputs): build outputs config even when using cache Mar 5, 2024
@laurent-laporte-pro
Copy link
Contributor

Good job! I only improve the unit tests to use fixtures.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Mar 25, 2024
@laurent-laporte-pro laurent-laporte-pro merged commit 36bc82e into dev Mar 25, 2024
5 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the fix/output-disappeared branch March 25, 2024 20:15
laurent-laporte-pro pushed a commit that referenced this pull request Apr 11, 2024
@MartinBelthle @laurent-laporte-pro
fix(outputs): build outputs config even when using cache (#1958)
e49bc96 
(cherry picked from commit 07cf7ca)
@laurent-laporte-pro laurent-laporte-pro mentioned this pull request Apr 11, 2024
Merged
17 tasks
@makdeuneuv makdeuneuv added this to the v2.16.8 milestone Apr 15, 2024
skamril pushed a commit that referenced this pull request Apr 19, 2024
@MartinBelthle @skamril
fix(outputs): build outputs config even when using cache (#1958)
1b1d073 
(cherry picked from commit 07cf7ca)
skamril pushed a commit that referenced this pull request Apr 19, 2024
@MartinBelthle @skamril
fix(outputs): build outputs config even when using cache (#1958)
88d4930 
(cherry picked from commit 07cf7ca)
@skamril skamril mentioned this pull request Apr 19, 2024
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-laporte-pro laurent-laporte-pro laurent-laporte-pro left review comments

Assignees

@MartinBelthle MartinBelthle

Labels
size/L
Projects
None yet
Milestone
v2.16.8
Development

Successfully merging this pull request may close these issues.

[AntaresWeb] Output disappeared
3 participants
@MartinBelthle @laurent-laporte-pro @makdeuneuv