Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(variant-db): correct foreign key constraints on variant study table #1943

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

laurent-laporte-pro
Copy link
Contributor

Cette PR corrige le problème de suppression d'une variante d'étude.

Modification apportées :

  • Ajout des contrainte ondelete="CASCADE" sur les clefs étrangères des tables CommandBlock et Snapshot.
  • Ajout d'un script de migration de la base de données (spécifique à PostgreSQL)
  • Ajout d'un test unitaire pour vérifier la suppression en cascade des RawStudy possédant des données additionnelle (additional_data).

L'anomalie est difficile à vérifier avec un test unitaire classique car les contraintes côté base de données ne sont pas vérifiées avec SQLite 👎🏻

Related to ANT-952

@laurent-laporte-pro laurent-laporte-pro added bug Something isn't working hot back-end labels Feb 21, 2024
@laurent-laporte-pro laurent-laporte-pro added this to the v2.16.5 milestone Feb 21, 2024
@laurent-laporte-pro laurent-laporte-pro self-assigned this Feb 21, 2024
@laurent-laporte-pro laurent-laporte-pro marked this pull request as ready for review February 21, 2024 16:48
@olfamizen olfamizen merged commit 721d18f into dev Feb 22, 2024
7 checks passed
@olfamizen olfamizen deleted the bugfix/952-correct-additional-data-casecade-delete branch February 22, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end bug Something isn't working hot size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants