Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(study-search): add a studies counting endpoint #1942

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

mabw-rte
Copy link
Contributor

Context:
Related to ANT-1107 (tags-db) and ANT-1106 (permissions-db), it happens that front-end can not predict the total number of studies matching some given filtering parameters, to perform the pagination properly.

Solution:
Add an endpoint that return the total studies count.

@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch 2 times, most recently from c344b32 to dd86776 Compare February 21, 2024 16:20
@mabw-rte mabw-rte self-assigned this Feb 21, 2024
@mabw-rte mabw-rte changed the title feat(permission-db): add a studies counting endpoint feat(study-search): add a studies counting endpoint Feb 21, 2024
@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch from dd86776 to 19bc940 Compare February 22, 2024 10:05
@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch from 19bc940 to 88c18bb Compare February 22, 2024 14:42
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai fais des commentaires dans la PR #1931, que tu peux valider.
Fais ensuite des corrections dans cette PR.

antarest/study/web/studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/studies_blueprint.py Outdated Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch 2 times, most recently from 411425b to 2f650db Compare February 23, 2024 10:47
Copy link
Contributor

@laurent-laporte-pro laurent-laporte-pro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La docstring du endpoint count_studies (et aussi get_studies) peut être simplifiée car il se trouve que les paramètres Query sont déjà bien documentés. Tu peux simplifier si tu le désire.

@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch from 7cd9b97 to a3571d5 Compare February 27, 2024 10:37
antarest/study/web/studies_blueprint.py Show resolved Hide resolved
antarest/study/web/studies_blueprint.py Show resolved Hide resolved
tests/integration/studies_blueprint/test_get_studies.py Outdated Show resolved Hide resolved
tests/integration/studies_blueprint/test_get_studies.py Outdated Show resolved Hide resolved
tests/integration/studies_blueprint/test_get_studies.py Outdated Show resolved Hide resolved
tests/study/test_repository.py Outdated Show resolved Hide resolved
tests/study/test_repository.py Show resolved Hide resolved
tests/study/test_repository.py Show resolved Hide resolved
@mabw-rte mabw-rte force-pushed the feature/1106-add-studies-counter-endpoint branch from 9173123 to ee959bc Compare February 27, 2024 14:05
@mabw-rte mabw-rte merged commit bae236d into dev Feb 27, 2024
7 checks passed
@mabw-rte mabw-rte deleted the feature/1106-add-studies-counter-endpoint branch February 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants