-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(study-search): add a studies counting endpoint #1942
Conversation
c344b32
to
dd86776
Compare
dd86776
to
19bc940
Compare
19bc940
to
88c18bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
J'ai fais des commentaires dans la PR #1931, que tu peux valider.
Fais ensuite des corrections dans cette PR.
411425b
to
2f650db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La docstring du endpoint count_studies
(et aussi get_studies
) peut être simplifiée car il se trouve que les paramètres Query
sont déjà bien documentés. Tu peux simplifier si tu le désire.
2f650db
to
36ea8ac
Compare
7cd9b97
to
a3571d5
Compare
9173123
to
ee959bc
Compare
Context:
Related to ANT-1107 (tags-db) and ANT-1106 (permissions-db), it happens that front-end can not predict the total number of studies matching some given filtering parameters, to perform the pagination properly.
Solution:
Add an endpoint that return the total studies count.