feat(hydro): add "Min Gen." tab to Hydro section for studies in v8.6 and later #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
force-pushed
the
feature/add-mingen-tab-frontend
branch
from
2826b6b to
6a2c4c5
Compare
laurent-laporte-pro
changed the title
skamril
force-pushed
the
feature/add-mingen-tab-frontend
branch
from
6a2c4c5 to
43bf505
Compare
hdinia
requested changes
Feb 13, 2024
| @@ -30,7 +31,8 @@ function Hydro() { | |||
| { label: "Water values", path: `${basePath}/watervalues` }, | |||
| { label: "Hydro Storage", path: `${basePath}/hydrostorage` }, | |||
| { label: "Run of river", path: `${basePath}/ror` }, | |||
| ]; | |||
| studyVersion >= 860 && { label: "Min Gen.", path: `${basePath}/mingen` }, | |||
| ].filter(Boolean); | |||
| }, [areaId, study?.id]); | |||
There was a problem hiding this comment.
missing dependency studyVersion here
| @@ -144,6 +149,11 @@ export const MATRICES: Matrices = { | |||
| url: "input/hydro/series/{areaId}/ror", | |||
| stats: MatrixStats.STATS, | |||
| }, | |||
| [HydroMatrixType.MinGen]: { | |||
| title: "Min Gen.", | |||
There was a problem hiding this comment.
Could you please remove all dots "." from tabs label, matrix title etc
hdinia
force-pushed
the
feature/add-mingen-tab-frontend
branch
from
8a8dccb to
e576108
Compare
hdinia
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new feature involves adding a "Min Gen." tab to the Hydro section. This tab is specifically for studies in version 8.6 or later. The "Min Gen." tab is dedicated to configuring the minimum generation levels of the hydraulic generators. It presents a time series that represents the minimum hourly production for one or more Monte-Carlo years.
The implementation includes:
HydroMatrixType,Testing: