feat(tags-db): populate tag and study_tag tables using pre-existing patch data in study_additional_data table
#1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent-laporte-pro
force-pushed
the
feature/1107-populate-tags-new-tables
branch
from
1423a12 to
3084923
Compare
laurent-laporte-pro
suggested changes
Feb 13, 2024
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
skamril
force-pushed
the
feature/1107-populate-tags-new-tables
branch
2 times, most recently
from
6fd4712 to
5ef35ad
Compare
laurent-laporte-pro
changed the title
tag and study_tag tables using pre-existing patch data in study_additional_data table
mabw-rte
changed the title
tag and study_tag tables using pre-existing patch data in study_additional_data tabletag and study_tag tables using pre-existing patch data in study_additional_data table
skamril
force-pushed
the
feature/1107-populate-tags-new-tables
branch
from
5ef35ad to
907fe57
Compare
mabw-rte
force-pushed
the
feature/1107-populate-tags-new-tables
branch
3 times, most recently
from
3a775b5 to
852d844
Compare
mabw-rte
force-pushed
the
feature/1107-populate-tags-new-tables
branch
from
852d844 to
5cf76cd
Compare
laurent-laporte-pro
suggested changes
Feb 13, 2024
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
laurent-laporte-pro
approved these changes
Feb 14, 2024
alembic/versions/dae93f1d9110_populate_tag_and_study_tag_tables_with_.py
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Currently, tags do not have a specific table but are directly retrieved from Patches using Python code.
Issue:
This coding paradigm results in filtering that cannot occur at the database level but rather post-query (posing a problem for pagination). It can also potentially slightly slow down API queries.
Solution in following steps:
tagandstudy_tag, to manage the many-to-many relationships between studies and tags. This step requires data migration.Note:
This PR deals with the last step