Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(tags-db): update tags related services and endpoints (#1925) #1925

Merged
merged 11 commits into from
Feb 8, 2024

Conversation

mabw-rte
Copy link
Contributor

@mabw-rte mabw-rte commented Feb 6, 2024

Context:
Currently, tags do not have a specific table but are directly retrieved from Patches using Python code.

Issue:
This coding paradigm results in filtering that cannot occur at the database level but rather post-query (posing a problem for pagination). It can also potentially slightly slow down API queries.

Solution in following steps:

  1. Create two tables, tag and study_tag, to manage the many-to-many relationships between studies and tags. This step requires data migration.
  2. Update endpoints and services
  3. Create an update script to populate the newly created tables with pre-existing data.

Note:
This PR deals with the second step.

@mabw-rte mabw-rte self-assigned this Feb 6, 2024
@mabw-rte mabw-rte force-pushed the feature/1107-tags-services-and-endpoints-update branch from 10293e0 to dac11fd Compare February 6, 2024 14:21
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Feb 7, 2024
@mabw-rte mabw-rte force-pushed the feature/1107-tags-services-and-endpoints-update branch from d2c8587 to 8e2800b Compare February 7, 2024 15:59
@laurent-laporte-pro laurent-laporte-pro changed the title feature(tags-db): update tags related services and endpoints feature(tags-db): update tags related services and endpoints (#1925) Feb 8, 2024
@mabw-rte mabw-rte merged commit bac31cb into dev Feb 8, 2024
6 checks passed
@mabw-rte mabw-rte deleted the feature/1107-tags-services-and-endpoints-update branch February 8, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants