-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-ui): add inflow structure form #1919
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdinia
changed the title
Feature/983 add inflow pattern form
feat(api-ui): add inflow pattern form
Jan 31, 2024
hdinia
force-pushed
the
feature/983-add-inflow-pattern-form
branch
3 times, most recently
from
January 31, 2024 15:45
e0ee786
to
be9f17b
Compare
hdinia
changed the title
feat(api-ui): add inflow pattern form
feat(api-ui): add inflow structure form
Jan 31, 2024
skamril
reviewed
Feb 1, 2024
...pp/src/components/App/Singlestudy/explore/Modelization/Areas/Hydro/InflowStructure/index.tsx
Outdated
Show resolved
Hide resolved
skamril
force-pushed
the
feature/983-add-inflow-pattern-form
branch
from
February 1, 2024 11:17
af903d7
to
1b8aa01
Compare
laurent-laporte-pro
force-pushed
the
feature/983-add-inflow-pattern-form
branch
from
February 1, 2024 15:19
9d07da0
to
4283833
Compare
laurent-laporte-pro
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ANT-983: https://gopro-tickets.rte-france.com/browse/ANT-983
This PR introduces backend and frontend changes to support the management of inflow structure form values within the hydraulic configuration of a study. It includes the implementation of RESTful API endpoints for retrieving and updating inflow structure values, as well as the corresponding frontend UI components to interact with these endpoints.
Backend Changes
New Endpoints:
GET
/studies/{study_id}/areas/{area_id}/hydro/inflowstructure
Retrieves the inflow structure form values for a given area of a study.
PUT
/studies/{study_id}/areas/{area_id}/hydro/inflowstructure
Updates the inflow structure form values for a given area of a study.
Models:
Introduced a new model
InflowStructure
to represent the inflow structure form values, currently encapsulating an inter_monthly_correlation field with validation constraints.Services:
Modified study_service to include
hydro_manager
methods for getting and updating the inflow structure values based on the study and area ID.Frontend Changes
InflowStructure
within the study configuration area to provide a UI for viewing and modifying the inflow structure values. This component includes validation and error handling for the input field.SplitHydroMatrix
to enable the display of a form in the same viewgetInflowStructureFields
andupdateInflowStructureField
s to interact with the backend API for fetching and updating inflow structure data.