Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raw): add endpoint for matrix download #1906

Merged
merged 41 commits into from
Feb 13, 2024

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Jan 24, 2024

Linked to [ANT-1051] on JIRA

NB:
1- I've put 10 minutes before download expiration. This is arbitrary and can be challenged.
2- The endpoint doesn't support .txt format as the front end already does
3- The enpoint doesn't support stats (ex. sum. or avg. at the end of certain matrices, load, ror, mod ...)
4- The dict SPECIFIC_MATRICES can have another structure as it is quite homemade for the moment, i'm open to any idea

@MartinBelthle MartinBelthle self-assigned this Jan 24, 2024
@MartinBelthle MartinBelthle force-pushed the add-endpoint-for-matrix-download branch 2 times, most recently from e03a878 to 286cbb1 Compare January 29, 2024 18:07
@MartinBelthle
Copy link
Contributor Author

Comparaison du temps de réponse du endpoint pour FileResponse VS StreamingResponse

benchmark

antarest/core/filetransfer/service.py Outdated Show resolved Hide resolved
antarest/core/filetransfer/service.py Outdated Show resolved Hide resolved
antarest/core/filetransfer/service.py Outdated Show resolved Hide resolved
antarest/study/service.py Outdated Show resolved Hide resolved
antarest/study/service.py Outdated Show resolved Hide resolved
antarest/study/storage/utils.py Outdated Show resolved Hide resolved
antarest/study/storage/utils.py Outdated Show resolved Hide resolved
antarest/study/storage/utils.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
@MartinBelthle MartinBelthle force-pushed the add-endpoint-for-matrix-download branch from e5e93b7 to 17ff437 Compare February 8, 2024 13:33
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
antarest/study/web/raw_studies_blueprint.py Outdated Show resolved Hide resolved
@laurent-laporte-pro laurent-laporte-pro force-pushed the add-endpoint-for-matrix-download branch 2 times, most recently from 7a2f9f1 to bf60841 Compare February 9, 2024 07:50
@laurent-laporte-pro laurent-laporte-pro marked this pull request as draft February 9, 2024 07:52
MartinBelthle and others added 20 commits February 12, 2024 22:22
…description` and `title`.

NOTE: `description` and `title` are displayed in the Swagger
…h_columns` to `with_header`

It is clearer for DataFrames.
- Ensure time series have "TS-NNN" headers.
- Output headers are not changed.
@laurent-laporte-pro laurent-laporte-pro force-pushed the add-endpoint-for-matrix-download branch from bf60841 to 6663e9e Compare February 13, 2024 09:26
@laurent-laporte-pro laurent-laporte-pro marked this pull request as ready for review February 13, 2024 09:28
@laurent-laporte-pro laurent-laporte-pro merged commit b7d98fd into dev Feb 13, 2024
6 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the add-endpoint-for-matrix-download branch February 13, 2024 10:07
@skamril skamril restored the add-endpoint-for-matrix-download branch February 13, 2024 13:27
@makdeuneuv makdeuneuv modified the milestones: v2.16.7, v2.17 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants