-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(raw): add endpoint for matrix download #1906
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
add-endpoint-for-matrix-download
branch
2 times, most recently
from
January 29, 2024 18:07
e03a878
to
286cbb1
Compare
MartinBelthle
force-pushed
the
add-endpoint-for-matrix-download
branch
from
January 30, 2024 16:03
9f27562
to
0c6ce7f
Compare
laurent-laporte-pro
suggested changes
Jan 30, 2024
MartinBelthle
force-pushed
the
add-endpoint-for-matrix-download
branch
3 times, most recently
from
February 6, 2024 10:37
a3086d9
to
5228043
Compare
MartinBelthle
force-pushed
the
add-endpoint-for-matrix-download
branch
from
February 8, 2024 13:33
e5e93b7
to
17ff437
Compare
laurent-laporte-pro
suggested changes
Feb 8, 2024
tests/integration/raw_studies_blueprint/test_download_matrices.py
Outdated
Show resolved
Hide resolved
tests/integration/raw_studies_blueprint/test_download_matrices.py
Outdated
Show resolved
Hide resolved
tests/integration/raw_studies_blueprint/test_download_matrices.py
Outdated
Show resolved
Hide resolved
tests/integration/raw_studies_blueprint/test_download_matrices.py
Outdated
Show resolved
Hide resolved
laurent-laporte-pro
force-pushed
the
add-endpoint-for-matrix-download
branch
2 times, most recently
from
February 9, 2024 07:50
7a2f9f1
to
bf60841
Compare
…TableExportFormat` enum
…e_matrix_files`)
…description` and `title`. NOTE: `description` and `title` are displayed in the Swagger
…h_columns` to `with_header` It is clearer for DataFrames.
…`matrix_profile` module
…token in unit tests
- Ensure time series have "TS-NNN" headers. - Output headers are not changed.
laurent-laporte-pro
force-pushed
the
add-endpoint-for-matrix-download
branch
from
February 13, 2024 09:26
bf60841
to
6663e9e
Compare
laurent-laporte-pro
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to [ANT-1051] on JIRA
NB:
1- I've put 10 minutes before download expiration. This is arbitrary and can be challenged.
2- The endpoint doesn't support
.txt
format as the front end already does3- The enpoint doesn't support stats (ex. sum. or avg. at the end of certain matrices, load, ror, mod ...)
4- The dict
SPECIFIC_MATRICES
can have another structure as it is quite homemade for the moment, i'm open to any idea