fix(bc): correct case sensitivity for binding constraint term IDs #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
2 times, most recently
from
28b9823 to
0f6db4e
Compare
1 task
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
0f6db4e to
aa63fba
Compare
laurent-laporte-pro
suggested changes
Jan 24, 2024
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
221b2a8 to
075c39a
Compare
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
075c39a to
3190cf1
Compare
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
3190cf1 to
29f0fb8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
hdinia
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
6 times, most recently
from
d2a1244 to
6f51372
Compare
hdinia
requested review from
laurent-laporte-pro
and removed request for
MartinBelthle and
skamril
laurent-laporte-pro
suggested changes
Jan 31, 2024
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
tests/integration/study_data_blueprint/test_binding_constraints.py
Outdated
Show resolved
Hide resolved
| raise ConstraintIdNotFoundError(study.id) | ||
|
|
||
| data_term_index = BindingConstraintManager.find_constraint_term_id(constraints, data_id) | ||
| if data_term_index < 0: | ||
| term_id_index = BindingConstraintManager.find_constraint_term_id(constraint_terms, term_id) |
There was a problem hiding this comment.
En fait, ici le code est moche car on fait une recherche d'index dans une liste. Tout serait plus simple si on avait un dict…
constraint_map = {term.id: term for term in constraint_terms}
...
if term_id in constraint_map:
...There was a problem hiding this comment.
je suis d'accord, c'est mieux, mon but ici n'était pas de faire un gros refactoring. je veux bien m'en occuper quand on fera une refonte du front
antarest/study/storage/variantstudy/business/utils_binding_constraint.py
Show resolved
Hide resolved
laurent-laporte-pro
approved these changes
Feb 1, 2024
laurent-laporte-pro
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
6f51372 to
c7184d8
Compare
laurent-laporte-pro
force-pushed
the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
from
c7184d8 to
b599f09
Compare
laurent-laporte-pro
deleted the
bugfix/fix-case-sensitivity-for-bc-constraint-term-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces changes to ensure consistent handling of case sensitivity in binding constraint term IDs across the backend and frontend. It also includes additional tests to validate this behavior.
Backend
Updated the
update_constraint_termfunction, to handle term IDs in a case-insensitive manner. This ensures that term IDs are processed consistently, regardless of their case.Modified ID comparisons and processing logic to use lowercase versions of term IDs, aligning with the frontend changes for uniformity and reducing the likelihood of mismatches due to case differences.
Frontend
In the
OptionsListcomponent, normalized the cluster IDs to lowercase. This change allow the frontend to display clusters names for BC terms regardless of their ID case.