Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-debug): issue to display json file in outputs #1747

Merged
merged 1 commit into from
Sep 30, 2023
Merged

fix(ui-debug): issue to display json file in outputs #1747

merged 1 commit into from
Sep 30, 2023

Conversation

skamril
Copy link
Member

@skamril skamril commented Sep 29, 2023

No description provided.

@skamril skamril linked an issue Sep 29, 2023 that may be closed by this pull request
Failed to display JSON file outputs in Debug view #1744
Closed
2 tasks
@commit-lint
Copy link

commit-lint bot commented Sep 29, 2023 •
edited
Loading

Bug Fixes

  • ui-debug: issue to display json file in outputs (e3a431c)

Contributors

skamril

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@skamril skamril self-assigned this Sep 29, 2023
@skamril skamril force-pushed the bugfix/1744-json-issue-debug-view branch from 3a2f695 to c4ad3e4 Compare September 29, 2023 09:52
@skamril skamril changed the base branch from dev to release/2.15 September 29, 2023 10:00
@skamril skamril force-pushed the bugfix/1744-json-issue-debug-view branch from c4ad3e4 to 18c1400 Compare September 29, 2023 10:04
@laurent-laporte-pro laurent-laporte-pro dismissed their stale review September 29, 2023 10:27

The merge-base changed after approval.

@skamril skamril force-pushed the bugfix/1744-json-issue-debug-view branch from e22b7d3 to e3a431c Compare September 29, 2023 13:44
@laurent-laporte-pro
Copy link
Contributor

This fix solves the problem of displaying JSON files in the Debug view:

image

I validate this PR ✅

@laurent-laporte-pro laurent-laporte-pro merged commit 9d30463 into release/2.15 Sep 30, 2023
8 checks passed
@laurent-laporte-pro laurent-laporte-pro deleted the bugfix/1744-json-issue-debug-view branch September 30, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-laporte-pro laurent-laporte-pro laurent-laporte-pro left review comments

@hdinia hdinia Awaiting requested review from hdinia

Assignees

@skamril skamril

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to display JSON file outputs in Debug view
2 participants
@skamril @laurent-laporte-pro