bugfix(matrix): correct the loading and saving of empty matrices as TSV files #1746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The purpose of this pull request is to address an issue encountered when generating empty matrices. In certain cases, empty matrices are saved in TSV format with a newline character instead of being saved as completely empty files.
The proposed solution involves modifying the code to save an empty file when the matrix is empty.
Additionally, when loading an empty file, it will be treated as a 2D empty matrix.
Technical Details
A 2D-NumPy array is considered empty if its
size
attribute is zero or if itsshape
is(1, 0)
. This corresponds to the Python array[[]]
.Changes Made
Testing
Unit tests have been enhanced to thoroughly validate the functionality of reading and writing empty matrices to disk in TSV format.
Related Issue
close #1731
Checklist