-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(api): correct API endpoints and CLI tools #1726
Merged
laurent-laporte-pro
merged 9 commits into
dev
from
bugfix/1724-correct-api-endpoints-and-cli-tools
Sep 6, 2023
Merged
fix(api): correct API endpoints and CLI tools #1726
laurent-laporte-pro
merged 9 commits into
dev
from
bugfix/1724-correct-api-endpoints-and-cli-tools
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Fixes
Tests
Code Refactoring
Continuous Integration
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
laurent-laporte-pro
force-pushed
the
bugfix/1724-correct-api-endpoints-and-cli-tools
branch
2 times, most recently
from
September 4, 2023 17:46
23d4585
to
fa551c6
Compare
TLAIDI
reviewed
Sep 5, 2023
laurent-laporte-pro
requested review from
hdinia
and removed request for
hdinia
September 6, 2023 06:37
hdinia
reviewed
Sep 6, 2023
hdinia
approved these changes
Sep 6, 2023
TLAIDI
approved these changes
Sep 6, 2023
The response model has been updated to `None`.
Corrects the JSON payloads for endpoints related to the "table mode" to properly convert enumerated values into strings.
The `update_area_ui` endpoint returns `None`.
…ytes for file upload Correct the unit tests for Xpansion-related endpoints to use `io.BytesIO` instead of `io.StringIO` for sending a file in multipart.
Starlette 0.21.0 introduced changes to the `TestClient` implementation by replacing the `requests` library with `httpx`. This commit corrects and updates unit tests in the `integration` directory to accommodate the new API and resolve breaking changes.
This commit prepares for migrating from Requests to httpx by adjusting imports and usage in LDAP, command line tools, and GUI code.
…equests and Httpx
… 0.24 Adjusted the construction of `UploadFile` objects in unit tests (changes in Starlette's API): the 'content_type' parameter has been removed.
laurent-laporte-pro
force-pushed
the
bugfix/1724-correct-api-endpoints-and-cli-tools
branch
from
September 6, 2023 09:56
fa551c6
to
6eab8ac
Compare
laurent-laporte-pro
deleted the
bugfix/1724-correct-api-endpoints-and-cli-tools
branch
September 6, 2023 11:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updates to the API endpoints and CLI tools as per the provided change log.
Summary
UploadFile
objects in unit tests to accommodate changes in Starlette's API (>= 0.24).Requests
tohttpx
by adjusting imports and usage in LDAP, command line tools, and GUI code.TestClient
implementation.io.BytesIO
for file uploads instead ofio.StringIO
.update_area_ui
endpoint to returnNone
.HTTPStatus.NO_CONTENT (204)
and updated the response model toNone
.Related Issues
Fixes #1724