Features/1646 refactoring request for study function #1669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Refactoring
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
4 tasks
antarest/study/service.py
Outdated
| self.storage_service.get_storage(target_study).export_study( | ||
| target_study, export_path, outputs | ||
| ) | ||
| if target_study.type == "ramstudy": |
There was a problem hiding this comment.
I think you meant rawstudy. To avoid this type of confusion, we usually do this in the code :
if isinstance(target_study, RawStudy):
antarest/study/service.py
Outdated
| return self.storage_service.get_storage(study).export_study_flat( | ||
| study, dest, len(output_list or []) > 0, output_list | ||
| path_study = Path(study.path) | ||
| if study.type == "rawstudy": |
| @@ -272,7 +330,16 @@ def export_study( | |||
| logger.info(f"Exporting study {metadata.id} to tmp path {tmpdir}") | |||
| assert_this(target.name.endswith(".zip")) | |||
| tmp_study_path = Path(tmpdir) / "tmp_copy" | |||
| self.export_study_flat(metadata, tmp_study_path, outputs) | |||
| if metadata.type != "rawstudy": | |||
added 3 commits
July 26, 2023 13:47
…https://github.com/AntaresSimulatorTeam/AntaREST into features/1646-Refactoring-request-for-study-function
MartinBelthle
approved these changes
Jul 26, 2023
skamril
pushed a commit
that referenced
this pull request
Jul 26, 2023
Co-authored-by: LAIDI Takfarinas (Externe) <[email protected]> Co-authored-by: TLAIDI <[email protected]>
This was referenced Jul 31, 2023
laurent-laporte-pro
pushed a commit
that referenced
this pull request
Aug 2, 2023
Co-authored-by: LAIDI Takfarinas (Externe) <[email protected]> Co-authored-by: TLAIDI <[email protected]>
laurent-laporte-pro
pushed a commit
that referenced
this pull request
Aug 2, 2023
Co-authored-by: LAIDI Takfarinas (Externe) <[email protected]> Co-authored-by: TLAIDI <[email protected]>
laurent-laporte-pro
pushed a commit
that referenced
this pull request
Sep 12, 2023
Co-authored-by: LAIDI Takfarinas (Externe) <[email protected]> Co-authored-by: TLAIDI <[email protected]>
laurent-laporte-pro
pushed a commit
that referenced
this pull request
Sep 12, 2023
Co-authored-by: LAIDI Takfarinas (Externe) <[email protected]> Co-authored-by: TLAIDI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.