feat(bc): make comments,

`filter_year_by_year` and `filter_synthesis` fields optional
AntaresSimulatorTeam · Mar 25, 2024 · 53b46da · 53b46da
1 parent a62b143
commit 53b46da
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 4 deletions.
diff --git a/antarest/study/storage/variantstudy/model/command/create_binding_constraint.py b/antarest/study/storage/variantstudy/model/command/create_binding_constraint.py
@@ -75,9 +75,9 @@ class BindingConstraintProperties(BaseModel, extra=Extra.forbid, allow_populatio
     enabled: bool = True
     time_step: BindingConstraintFrequency = BindingConstraintFrequency.HOURLY
     operator: BindingConstraintOperator = BindingConstraintOperator.EQUAL
-    comments: str = ""
-    filter_year_by_year: str = ""
-    filter_synthesis: str = ""
+    comments: t.Optional[str] = None
+    filter_year_by_year: t.Optional[str] = None
+    filter_synthesis: t.Optional[str] = None
 
 
 class BindingConstraintProperties870(BindingConstraintProperties):

diff --git a/tests/variantstudy/test_command_factory.py b/tests/variantstudy/test_command_factory.py
@@ -132,6 +132,9 @@ def setup_class(self):
                     "operator": "equal",
                     "coeffs": {},
                     "values": "values",
+                    "comments": "",
+                    "filter_synthesis": "",
+                    "filter_year_by_year": "",
                 },
             ),
             CommandDTO(
@@ -144,7 +147,10 @@ def setup_class(self):
                         "operator": "equal",
                         "coeffs": {},
                         "values": "values",
-                    }
+                        "comments": "",
+                        "filter_synthesis": "",
+                        "filter_year_by_year": "",
+                    },
                 ],
             ),
             CommandDTO(
@@ -156,6 +162,9 @@ def setup_class(self):
                     "operator": "equal",
                     "coeffs": {},
                     "values": "values",
+                    "comments": "",
+                    "filter_synthesis": "",
+                    "filter_year_by_year": "",
                 },
             ),
             CommandDTO(
@@ -167,6 +176,9 @@ def setup_class(self):
                         "time_step": "hourly",
                         "operator": "equal",
                         "coeffs": {},
+                        "comments": "",
+                        "filter_synthesis": "",
+                        "filter_year_by_year": "",
                     }
                 ],
             ),