Skip to content

Commit

Permalink
build: fix issue with desktop app packaging for Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
skamril committed Jan 31, 2024
1 parent 60957a7 commit 52977cd
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
branches:
- "master"
- "hotfix/**"
- "bugfix/desktop_build_windows"

jobs:
binary:
Expand Down
2 changes: 1 addition & 1 deletion scripts/build-front.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ cd "$CURR_DIR"/../webapp

# When the web application is running in Desktop mode,
# the web app is served at the `/static` entry point.
npm run build -- --base=/static/
npm run build -- --mode=desktop-app

cd ..
rm -fr resources/webapp
Expand Down
1 change: 1 addition & 0 deletions webapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
"type": "module",
"scripts": {
"build": "tsc && vite build",
"buildDesktop": "set VITE_APP_BASE=/static/ && npm run build",
"clean": "rm -rf dist node_modules/.vite",
"dev": "vite",
"lint": "tsc --noEmit && eslint . --ext ts,tsx --report-unused-disable-directives",
Expand Down
1 change: 1 addition & 0 deletions webapp/vite.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const SERVER_URL = "http://localhost:8080";

// https://vitejs.dev/config/
export default defineConfig({
base: process.env.VITE_BASE_URL || "/",
plugins: [react({ devTarget: "es2022" })],
server: {
port: 3000,
Expand Down

0 comments on commit 52977cd

Please sign in to comment.