feat(bc): add new exception for incoherent matrix

AntaresSimulatorTeam · Jan 4, 2024 · 339c932 · 339c932
1 parent 151765a
commit 339c932
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/antarest/core/exceptions.py b/antarest/core/exceptions.py
@@ -199,6 +199,11 @@ def __init__(self, message: str) -> None:
         super().__init__(HTTPStatus.BAD_REQUEST, message)
 
 
+class IncoherentConstraintMatrixTerm(HTTPException):
+    def __init__(self, message: str) -> None:
+        super().__init__(HTTPStatus.BAD_REQUEST, message)
+
+
 class MissingDataError(HTTPException):
     def __init__(self, message: str) -> None:
         super().__init__(HTTPStatus.NOT_FOUND, message)

diff --git a/antarest/study/business/binding_constraint_management.py b/antarest/study/business/binding_constraint_management.py
@@ -6,6 +6,7 @@
     ConstraintAlreadyExistError,
     ConstraintIdNotFoundError,
     DuplicateConstraintName,
+    IncoherentConstraintMatrixTerm,
     InvalidConstraintName,
     MissingDataError,
     NoBindingConstraintError,
@@ -191,9 +192,11 @@ def create_binding_constraint(
 
         if int(study.version) >= 870:
             if data.values is not None:
-                raise ValueError("You cannot fill 'values' as it refers to the matrix before v8.7")
+                raise IncoherentConstraintMatrixTerm("You cannot fill 'values' as it refers to the matrix before v8.7")
         elif any([data.equal_term_matrix, data.less_term_matrix, data.greater_term_matrix]):
-            raise ValueError("You cannot fill a 'matrix_term' as these values refer to v8.7+ studies")
+            raise IncoherentConstraintMatrixTerm(
+                "You cannot fill a 'matrix_term' as these values refer to v8.7+ studies"
+            )
 
         command = CreateBindingConstraint(
             name=data.name,