Fix generate to return results in submission order #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
generate
to return generation results in theinputs
order, rather than in the order generation jobs completed.It still submits the jobs in
inputs
order, so the jobs will start ininputs
order.It relies on
as_completed
to determine, to update the progress bar whenever a job is completed.This does not add any timeout or error handling logic, so we are still relying on the user to build that into job definitions -- e.g., to define jobs such that they will return None after a timeout period or in the event of an error.
I have lightly tested it, by executing 50 jobs with 5 workers, and inspecting results. Let's discuss @ncoop57