[HF] Let server decide default repo visibility #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wauplin
changed the title
|
Hey @Wauplin , thanks so much for the PR!! However, since this is an nbdev project, development is a bit different than from what you are probably use to. You need to make changes to the jupyter notebooks and then export them in order for it to work properly. You can read more about it in this awesome CONTRIBUTING.md file (I'll add one here for future people!) https://github.com/AnswerDotAI/fasthtml/blob/main/CONTRIBUTING.md. Could you please update your PR to work with nbdev? |
|
@ncoop57 Done! |
|
Awesome, thanks so much @Wauplin !! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, all repos were public by default when created without passing the private argument. This meant that passing private=False or private=None was strictly the same. This is not the case anymore. Enterprise Hub offers organizations to set a default visibility setting for new repos. This is useful for organizations forbidding public repos for security matters. This PR updates the default value to follow this principle.
Related to huggingface/huggingface_hub#2679 and #9