Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kishibe Rohan wa Ugokanai: fix mapping #134

Closed
wants to merge 1 commit into from

Conversation

hypevhs
Copy link

@hypevhs hypevhs commented Feb 22, 2022

Kishibe Rohan wa Ugokanai maps to the tvdb entry for the entire JoJo (2012) series, under Specials.

Before this commit, Kishibe Rohan S01E01 maps to tvdb-S00E01 (Millionaire Village), but also tvdb-S01E01 (Dio the Invader). Agents might unfortunately pick the latter for metadata. This commit "clears out space" in S01 by mapping the first four episodes to Season 99.

I've tested this and it works. Is there a cleaner method?

@BrutuZ
Copy link

BrutuZ commented May 7, 2022

That kind of mismatch sounds more like a conflict caused by file organization and may be more properly fixed with https://github.com/ZeroQI/Absolute-Series-Scanner#forcing-the-movieseries-id

@BrutuZ BrutuZ closed this May 7, 2022
@hypevhs
Copy link
Author

hypevhs commented May 24, 2022

@BrutuZ I'm not sure. This occurs even after forcing [anidb-].

I just ran into this again with Gekijouban Soushuuhen Made in Abyss. The logs look like this:

https://gist.github.com/libjared/59825621cb37d1aea428fc11fbd950c8

Notice how for a dir containing just 2 files (01 Journey's Dawn, 02 Wandering Twilight) and completely separate from the TV series, it opts to grab 4 episodes worth of metadata from TVDB: S{0,1}E{1,2}. Because "s01e001" is now a many-to-one mapping, Hama is free to decide which episode that refers to. It then prefers S1, so Journey's Dawn is tagged as The City of the Great Pit.

I'm not sure how else you'd fix this without mapping to S99.

@BrutuZ
Copy link

BrutuZ commented May 24, 2022

Mapping to a non-existing season is a workaround (not a fix) to a bug in Hama so that should be fixed instead.

Maybe anime-list-corrections.xml is a better place for this method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants