Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-identify the XML namespace Issue 20 #21

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

jbrayfaithlife
Copy link
Contributor

While the XML namespace may be declared it does not have to be in order to use xml namespaced attributes. This code will automatically recognize xml namespaced attributes, even if the namespace is not explicitly declared.

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • [/] I have read the CONTRIBUTING document
  • [/] My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • [/] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • [/] I have added tests to cover my changes
  • [/] All new and existing tests passed

Description

This code change automatically associates any xml prefixed attribute with the xml namespace, without checking to see if is has been explicitly declared.

While the XML namespace may be declared it does not have to be in order
to use xml namespaced attributes. This code will automatically recognize
xml namespaced attributes, even if the namespace is not explicitly
declared.
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2023

CLA assistant check
All committers have signed the CLA.

@jbrayfaithlife jbrayfaithlife changed the title Auto-identify the XML namespace Issue 22 Auto-identify the XML namespace Issue 20 Apr 18, 2023
Copy link

@mavaddat mavaddat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! This looks like a reasonable way to automatically recognize the implicit XML namespace.

@FlorianRappl
Copy link
Contributor

Yes I would love to merge it, but the CLA is not signed for this one.

cc @jbrayfaithlife

@ddunkin
Copy link

ddunkin commented Aug 24, 2023

The CLA is now signed.

@FlorianRappl FlorianRappl merged commit 274e8d9 into AngleSharp:devel Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants