Merge pull request #7 from kasthack/feature/issues-6-allow-diamond-br…

…acket-in-attributes Allow to suppress '<' validation for attribute values
AngleSharp · Jul 31, 2019 · 4595c86 · 4595c86
2 parents fdf519c + 21a44ed
commit 4595c86
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/src/AngleSharp.Xml.Tests/Tokenizer/XmlTokenization.cs b/src/AngleSharp.Xml.Tests/Tokenizer/XmlTokenization.cs
@@ -182,5 +182,32 @@ public void XmlTokenizerTagWithAttributeContainingEntity()
             Assert.AreEqual("bar", foo.Attributes[0].Key);
             Assert.AreEqual("\"quz\"", foo.Attributes[0].Value);
         }
+
+        [Test]
+        public void XmlTokenizerTagThrowsWithADiamond()
+        {
+            var s = new TextSource("<foo bar=\"a < b\">");
+
+            var t = CreateTokenizer(s);
+            t.IsSuppressingErrors = false;
+            Assert.Throws<XmlParseException>(() => t.Get());
+        }
+
+        [Test]
+        public void XmlTokenizerTagSuppressesWithADiamond()
+        {
+            var s = new TextSource("<foo bar=\"a < b\">");
+            var t = CreateTokenizer(s);
+            t.IsSuppressingErrors = true;
+            var foo = t.Get() as XmlTagToken;
+
+            Assert.IsNotNull(foo);
+            Assert.AreEqual(XmlTokenType.StartTag, foo.Type);
+            Assert.IsFalse(foo.IsSelfClosing);
+            Assert.AreEqual("foo", foo.Name);
+            Assert.AreEqual(1, foo.Attributes.Count);
+            Assert.AreEqual("bar", foo.Attributes[0].Key);
+            Assert.AreEqual("a < b", foo.Attributes[0].Value);
+        }
     }
 }
diff --git a/src/AngleSharp.Xml/Parser/XmlTokenizer.cs b/src/AngleSharp.Xml/Parser/XmlTokenizer.cs
@@ -1046,7 +1046,7 @@ private XmlToken AttributeValue(XmlTagToken tag, Char quote)
                 if (c == Symbols.EndOfFile)
                     throw XmlParseError.EOF.At(GetCurrentPosition());
 
-                if (c == Symbols.LessThan)
+                if (c == Symbols.LessThan && !IsSuppressingErrors)
                     throw XmlParseError.XmlLtInAttributeValue.At(GetCurrentPosition());
 
                 if (c == Symbols.Ampersand)