Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Jint 3.1.0 #95

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Upgrade to Jint 3.1.0 #95

merged 1 commit into from
Apr 13, 2024

Conversation

lahma
Copy link
Contributor

@lahma lahma commented Apr 13, 2024

Types of Changes

Prerequisites

Please make sure you can check the following two boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Description

  • upgrade Jint to Jint 3.1, remove obsolete member usage with better ones
  • small cleanup to API usage
  • add missing license expression to csproj
  • treat warnings as errors to catch obsolete members

@CLAassistant
Copy link

CLAassistant commented Apr 13, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@lahma
Upgrade to Jint 3.1.0
37d4fa3 
* small cleanup to API usage
* add missing license expression
* treat warnings as errors to catch obsolete members
FlorianRappl
FlorianRappl requested changes Apr 13, 2024
View reviewed changes
src/AngleSharp.Js/AngleSharp.Js.csproj Show resolved Hide resolved
src/Directory.Build.props Show resolved Hide resolved
@FlorianRappl FlorianRappl merged commit 551f1d3 into AngleSharp:devel Apr 13, 2024
5 checks passed
@lahma lahma deleted the jint-3.1.0 branch June 29, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianRappl FlorianRappl FlorianRappl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahma @CLAassistant @FlorianRappl