Skip to content

Commit

Permalink
Merge pull request ethereum#13481 from ethereum/fix-artifacts-check-i…
Browse files Browse the repository at this point in the history
…n-hardhat-external-tests

Fix compiler version check in hardhat artifacts json
  • Loading branch information
ekpyron authored Sep 5, 2022
2 parents 6b99162 + e5769d7 commit 99f15ff
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/externalTests/common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -357,8 +357,8 @@ function hardhat_verify_compiler_version
local build_info_files
build_info_files=$(find . -path '*artifacts/build-info/*.json')
for build_info_file in $build_info_files; do
grep '"solcVersion": "'"${solc_version}"'"' --with-filename "$build_info_file" || fail "Wrong compiler version detected in ${build_info_file}."
grep '"solcLongVersion": "'"${full_solc_version}"'"' --with-filename "$build_info_file" || fail "Wrong compiler version detected in ${build_info_file}."
grep '"solcVersion":[[:blank:]]*"'"${solc_version}"'"' --with-filename "$build_info_file" || fail "Wrong compiler version detected in ${build_info_file}."
grep '"solcLongVersion":[[:blank:]]*"'"${full_solc_version}"'"' --with-filename "$build_info_file" || fail "Wrong compiler version detected in ${build_info_file}."
done
}

Expand Down
2 changes: 2 additions & 0 deletions test/externalTests/zeppelin.sh
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,8 @@ function zeppelin_test
sed -i "s|it(\('other accounts cannot unpause'\)|it.skip(\1|g" test/token/ERC721/presets/ERC721PresetMinterPauserAutoId.test.js
sed -i "s|it(\('prevents initialization'\)|it.skip(\1|g" test/proxy/utils/Initializable.test.js
sed -i "s|it(\('divide by 0'\)|it.skip(\1|g" test/utils/math/Math.test.js
sed -i "s|it(\('pending owner resets after renouncing ownership'\)|it.skip(\1|g" test/access/Ownable2Step.test.js
sed -i "s|it(\('guards transfer against invalid user'\)|it.skip(\1|g" test/access/Ownable2Step.test.js
# CAUTION:: The following two sed commands depend on the order of occurrence of the relevant patterns in the mentioned files.
# Could result in an error in the future.
sed -zi "s|it(\('deposit'\)|it.skip(\1|3" test/token/ERC20/extensions/ERC4626.test.js
Expand Down

0 comments on commit 99f15ff

Please sign in to comment.