Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for protractor 4.x #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

floribon
Copy link

@floribon floribon commented Sep 4, 2016

Some breaking changes have been introduced since protractor 4.0.0 that this PR fixes.

It also allows the user to return this.quit() since cucumberjs accepts promises instead of forcing the use of a callback.

Contributions to this fork are welcome until this has been merged here.

@floribon
Copy link
Author

Note: if you are using protractor 5.x instead of 4x, replace these lines:

// Syntax for protractor 4.x
var browser = protractor.ProtractorBrowser.wrapDriver(driver);

// Syntax for protractor 5.x
var browser = new protractor.ProtractorBrowser(driver);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant