Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check foreign_identifier_lookup when inserting with an entity type. #231

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

Anders429
Copy link
Owner

Fixes #230. See the comments there for explanation.

@Anders429 Anders429 added C - Bug Category: Something is not functioning as expected. P - High Priority: Urgent, needing immediate attention. F - serde Feature: Serialization and deserialization through the serde library. labels Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #231 (208618b) into dev (d77d140) will increase coverage by 0.04%.
Report is 3 commits behind head on dev.
The diff coverage is 93.47%.

@@            Coverage Diff             @@
##              dev     #231      +/-   ##
==========================================
+ Coverage   97.07%   97.12%   +0.04%     
==========================================
  Files          84       84              
  Lines       14552    14564      +12     
==========================================
+ Hits        14127    14145      +18     
+ Misses        425      419       -6     
Files Changed Coverage Δ
src/entity/allocator/location.rs 76.92% <0.00%> (+5.49%) ⬆️
src/system/schedule/sendable.rs 66.66% <0.00%> (ø)
src/archetypes/mod.rs 99.17% <96.15%> (-0.01%) ⬇️
src/archetype/identifier/mod.rs 95.01% <100.00%> (-0.08%) ⬇️
src/query/mod.rs 100.00% <100.00%> (ø)
src/world/impl_serde.rs 99.28% <100.00%> (+0.02%) ⬆️

... and 4 files with indirect coverage changes

@Anders429 Anders429 merged commit 9f3654d into dev Aug 10, 2023
35 of 36 checks passed
@Anders429 Anders429 deleted the serde_bug branch August 10, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - Bug Category: Something is not functioning as expected. F - serde Feature: Serialization and deserialization through the serde library. P - High Priority: Urgent, needing immediate attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant