Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds dark mode #35

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Adds dark mode #35

wants to merge 1 commit into from

Conversation

A-Guldborg
Copy link
Contributor

This PR aims to add dark-mode, since we are getting compiler warnings that the Palette is deprecated and we should change to PaletteLight (+ PaletteDark).

This uses the system default preference on first render, but if the user actively changes the setting it is supposed to stay changed (currently, this restarts on full refresh / navigate to page anew but not on navigating through the site - see subtasks).

Most of the colors are based on what @marfavi liked, though in my opinion the dark mode is a little too dark...? But please help me with inputs on this :) I have attempted to find a good text-color that can be used instead.
I am also considering "bundling" same colors together (such that we don't define the textcolor three different places to be the same value).

Subtasks

This PR is a draft and is missing two main features:

  • Using localstorage to save user preference if they actively change it
  • Figure out a way to handle "deactivated" menuitems/products (Please come with feedback/ideas on how we can handle this, e.g. a global darkmode variable, only changing non-color related stylings or similar)

@A-Guldborg A-Guldborg added the enhancement New feature or request label Apr 16, 2024
@A-Guldborg A-Guldborg self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant