-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Product Manager #20
Conversation
Almost done. Few things:
(But I will need to test that before creating such a PR). Once at least the second issue mentioned here is fixed, this PR is ready for review) |
Update: PR is merged. |
The API adds the endpoint GET /api/v2/products/all, which returns all products, regardless of usergroup or visibility. This endpoint will be used for the product management frontend in AnalogIO/shifty-webapp#20, discussed in #217 (and slack). This endpoint is only accessible for users with Board privileges and will allow board members to manage the visibilty of products or products that they otherwise don't have access to themselves in the app. --------- Co-authored-by: Omid Marfavi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I request all changes in #22 to be merged before continuing, which fixes the horizontal scrolling in the table.
And I renamed your PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
…gle select dropdown
Removed sorting by columns to shorten column size. Removed filtering by hidden/unhidden elements. Removed trailing whitespace. Made the table more dense. Eye icon is no longer brown.
a72da0f
to
8779d8d
Compare
Closes #7
Enables adding and updating products through the Shifty app.
Note, a couple things to be discussed:
Please give inputs to the above discussion points and/or anything else :)
NB: Blocked until AnalogIO/analog-core#237 is merged as we require the endpoint created in that PR.