Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polygon block finality #254

Merged
merged 13 commits into from
Sep 4, 2024
Merged

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Sep 2, 2024

Description

Fixes Polygon block finality issue.

Created the trait BlockProvider, it abstract all chain specific logic to retrieve finalized blocks:

  • For polygon, it waits for an specific number of confirmations
  • For Astar, it retrieves the block using Substrate interface instead eth_getBlockBy*, once the eth interface has bug where the block contains wrong timestamp and block fee info.
  • For the remaining networks, it use the latest block tag.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Sorry, something went wrong.

@Lohann Lohann changed the title Fix polygon block finality issue Fix polygon block finality Sep 2, 2024
@Lohann Lohann merged commit 80821ac into master Sep 4, 2024
9 checks passed
@Lohann Lohann deleted the feature/issue-1003-wait-for-finality branch September 4, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants