Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polygon network to Ethereum Connector #174

Merged
merged 8 commits into from
Sep 22, 2023
Merged

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Sep 21, 2023

Description

Add polygon config to ethereum connector

Type of change

  • New feature (non-breaking change which adds functionality)

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann changed the title Feature/add polygon config Add polygon network to Ethereum Connector Sep 21, 2023
@4meta5
Copy link

4meta5 commented Sep 21, 2023

should add Polygon to Blockchain enum like in this PR right #175

@Lohann
Copy link
Collaborator Author

Lohann commented Sep 21, 2023

@4meta5 done!

Copy link

@4meta5 4meta5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not see any changes to the enum Blockchain. We need to add Blockchain::Polygon right?

@Lohann
Copy link
Collaborator Author

Lohann commented Sep 21, 2023

@4meta5 Blockchain::Polygon only exists on master branch, which we merge the connector into the timechain, the staging environment is still using the connector as a service, which don't have the enum Blockchain

@Lohann Lohann merged commit 36a48de into staging Sep 22, 2023
@isabellelaususan isabellelaususan linked an issue Sep 26, 2023 that may be closed by this pull request
@isabellelaususan isabellelaususan added connector Connector parent epic release-oct labels Sep 29, 2023
@Lohann Lohann mentioned this pull request Oct 12, 2023
@Lohann Lohann deleted the feature/add-polygon-config branch October 30, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connector Connector parent epic release-oct
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polygon Connector
3 participants