Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Polygon PoS Connector #135

Closed
wants to merge 4 commits into from
Closed

Conversation

Lohann
Copy link
Collaborator

@Lohann Lohann commented Jul 7, 2023

Description

Polygon PoS connector, still work in progress, I had some bad times getting everything working in my m1 mac 🙃

Fixes #126

Type of change

  • New feature (non-breaking change which adds functionality)

Tests

TODO

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@Lohann Lohann requested a review from dvc94ch July 7, 2023 09:04
@Lohann Lohann changed the title WIP: Support Polygon PoS WIP: Polygon PoS Connector Jul 7, 2023
build_connectors.sh Outdated Show resolved Hide resolved
docker-compose.yml Outdated Show resolved Hide resolved

pub const FEE_OP_TYPE: &str = "FEE";
pub const CALL_OP_TYPE: &str = "CALL";
pub const MINING_REWARD_OP_TYPE: &str = "MINER_REWARD";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to copy everything? I think just creating a new config crate should be enough

ci/dockerfiles/builder/Dockerfile Outdated Show resolved Hide resolved
build_connectors.sh Outdated Show resolved Hide resolved
.dockerignore Show resolved Hide resolved
@Lohann
Copy link
Collaborator Author

Lohann commented Jul 20, 2023

I'm closing this PR because I've decided to split the changes in a few others, just one extra config crate will be required for polygon, the ethereum server and and tx crates can be reused.

@Lohann Lohann closed this Jul 20, 2023
@dvc94ch dvc94ch deleted the feature/support-polygon-pos branch September 7, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polygon Connector
2 participants