pysoundfile 0.12.1 ❄️ #1

psteyer · 2024-09-26T00:12:57Z

pysoundfile 0.12.1 ❄️

Destination channel: Snowflake

Links

PKG-5718
dev_url: https://github.com/bastibe/python-soundfile/tree/0.12.1
conda_forge: https://github.com/conda-forge/pysoundfile-feedstock/blob/main/recipe/meta.yaml
pypi: https://pypi.org/project/soundfile/0.12.1
pypi inspector: https://inspector.pypi.io/project/soundfile/0.12.1
dependency for:

wfdb <- pysoundfile <- libsndfile <- libopus

Explanation of changes:

new recipe build
Skipping Windows and s390x for missing dependency libsnfile
- see: [PKG-5559] Initial build 1.2.2 ❄️ libsndfile-feedstock#1
current source does not bring in a vendored libsndfile, but added a patch and a line in the recipe to make sure.
required rebuilds of libopus and libsndfile, which then solved earlier test failures.

anaconda-pkg-build · 2024-09-26T14:37:11Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_c5vkbnzan2/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

clone/recipe/meta.yaml:32: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:64: documentation_specifies_language: Use the generic link, not a language specific one
clone/recipe/meta.yaml:64: invalid_url: https://python-soundfile.readthedocs.io/en/latest/ : Not reachable: 403
clone/recipe/meta.yaml:53: invalid_url: https://python-soundfile.readthedocs.io/ : Not reachable: 403

===== ERRORS =====

clone/recipe/meta.yaml:50: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 4 Warnings were found

anaconda-pkg-build · 2024-09-26T16:36:14Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_4b4gflhn02/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

clone/recipe/meta.yaml:64: documentation_specifies_language: Use the generic link, not a language specific one
clone/recipe/meta.yaml:32: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:64: invalid_url: https://python-soundfile.readthedocs.io/en/latest/ : Not reachable: 403
clone/recipe/meta.yaml:53: invalid_url: https://python-soundfile.readthedocs.io/ : Not reachable: 403

===== ERRORS =====

clone/recipe/meta.yaml:50: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 4 Warnings were found

anaconda-pkg-build · 2024-09-26T16:59:29Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_4b3yy4bzfc/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

clone/recipe/meta.yaml:58: documentation_specifies_language: Use the generic link, not a language specific one
clone/recipe/meta.yaml:47: invalid_url: https://python-soundfile.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:58: invalid_url: https://python-soundfile.readthedocs.io/en/latest/ : Not reachable: 403
clone/recipe/meta.yaml:26: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.

===== ERRORS =====

clone/recipe/meta.yaml:44: missing_pip_check: For pypi packages, pip check should be present in the test commands
===== Final Report: =====
1 Error and 4 Warnings were found

anaconda-pkg-build · 2024-09-27T15:44:47Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_abye0cmolr/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

clone/recipe/meta.yaml:31: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:63: documentation_specifies_language: Use the generic link, not a language specific one
clone/recipe/meta.yaml:52: invalid_url: https://python-soundfile.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:63: invalid_url: https://python-soundfile.readthedocs.io/en/latest/ : Not reachable: 403

===== ERRORS =====

clone/recipe/meta.yaml:49: missing_pip_check: For pypi packages, pip check should be present in the test commands
clone/recipe/meta.yaml:20: patch_unnecessary: patch should not be in build when source/patches is not set
===== Final Report: =====
2 Errors and 4 Warnings were found

anaconda-pkg-build · 2024-09-27T20:14:13Z

Linter check found the following problems:

Traceback (most recent call last): File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 208, in main return_code, report = execute_linter( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/run.py", line 180, in execute_linter result = linter.lint(recipes, subdir, variant_config_files, exclusive_config_files, fix_flag) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 728, in lint msgs = self.lint_file( ^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 834, in lint_file self.lint_recipe( File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 894, in lint_recipe res = self.check_instances[check].run(recipe, fix) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/__init__.py", line 294, in run self.check_recipe(recipe) File "/opt/conda/envs/linter/lib/python3.12/site-packages/anaconda_linter/lint/check_syntax.py", line 35, in check_recipe ro_parser: Final[RecipeParser] = recipe.get_read_only_parser() ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/render/recipe.py", line 675, in get_read_only_parser return RecipeParser("\n".join(self.meta_yaml)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/opt/conda/envs/linter/lib/python3.12/site-packages/percy/parser/recipe_parser.py", line 372, in __init__ parent = node_stack[-1] ~~~~~~~~~~^^^^ IndexError: list index out of range

ERROR conda.cli.main_run:execute(125): conda run conda-lint /tmp/abs_907mx88ge4/clone failed. (See above for error)

JeanChristopheMorinPerso · 2024-09-27T20:41:16Z

recipe/meta.yaml

- - export PYSOUNDFILE_PLATFORM=win32
- - python -m pip install . --no-deps -vv
+ # To make sure we really do not bring in _soundfile_data
+ - rm -rf _soundfile_data


This will fail on Windows

windows is skipped anyway

Since it's being skipped on windows anyways no need to add anything correct?

I think it's fine personally

JeanChristopheMorinPerso · 2024-09-27T20:44:02Z

recipe/meta.yaml

- python -c "import soundfile; print(soundfile._libname)"
+ # Verify that soundfile is linking the correct libsndfile object
+ - python -c "import soundfile; print(soundfile._libname)"
+ - pytest -vv . -k "not (test_available_formats or test_available_subtypes)"


Why do you skip test_available_formats and test_available_subtypes?

yes, a comment here would be good

I was unable to get the tests to run. It seems that there is one format format and one subtype that are throwing assertion errors, maybe they are missing, or the wrapper is doing something strange?

See failures:

=================================== FAILURES =================================== ____________________________ test_available_formats ____________________________ def test_available_formats(): formats = sf.available_formats() assert 'WAV' in formats > assert 'OGG' in formats E AssertionError: assert 'OGG' in {'AIFF': 'AIFF (Apple/SGI)', 'AU': 'AU (Sun/NeXT)', 'AVR': 'AVR (Audio Visual Research)', 'CAF': 'CAF (Apple Core Audio File)', ...} tests/test_soundfile.py:1005: AssertionError ___________________________ test_available_subtypes ____________________________ def test_available_subtypes(): subtypes = sf.available_subtypes() assert 'PCM_24' in subtypes assert 'FLOAT' in subtypes > assert 'VORBIS' in subtypes E AssertionError: assert 'VORBIS' in {'ALAC_16': '16 bit ALAC', 'ALAC_20': '20 bit ALAC', 'ALAC_24': '24 bit ALAC', 'ALAC_32': '32 bit ALAC', ...} tests/test_soundfile.py:1013: AssertionError

I'm not exactly sure how to proceed. I'm currently building the parent package wfdb to see if this would cause a problem farther down the road.

well it looks like you haven't got ogg vorbis enabled. Maybe your libsndfile hasn't been compiled with that support enabled, or maybe something else. Does snowflake want ogg vorbis support? if so, you'd need to fix it

danpetry · 2024-10-01T16:20:00Z

recipe/meta.yaml

- - export PYSOUNDFILE_PLATFORM=win32
- - python -m pip install . --no-deps -vv
+ # To make sure we really do not bring in _soundfile_data
+ - rm -rf _soundfile_data


windows is skipped anyway

danpetry · 2024-10-01T16:35:23Z

recipe/meta.yaml

- # Verify that soundfile is linking the correct libsndfile object
- python -c "import soundfile; print(soundfile._libname)"
+ # Verify that soundfile is linking the correct libsndfile object
+ - python -c "import soundfile; print(soundfile._libname)"


what should be the correct libname? It might be nicer to fail if not correct

This came in when forked from conda-forge. I can remove it and see if it's necessary.

You could pipe the output from this into something that checks that the text output from print(soundfile._libname) is correct

danpetry · 2024-10-01T16:35:44Z

recipe/meta.yaml

- python -c "import soundfile; print(soundfile._libname)"
+ # Verify that soundfile is linking the correct libsndfile object
+ - python -c "import soundfile; print(soundfile._libname)"
+ - pytest -vv . -k "not (test_available_formats or test_available_subtypes)"


yes, a comment here would be good

anaconda-pkg-build · 2024-10-03T18:46:31Z

Linter check found the following problems:

ERROR conda.cli.main_run:execute(125): `conda run conda-lint /tmp/abs_99wz0tl4xq/clone` failed. (See above for error) The following problems have been found:

===== WARNINGS =====

clone/recipe/meta.yaml:66: invalid_url: https://python-soundfile.readthedocs.io/en/latest/ : Not reachable: 403
clone/recipe/meta.yaml:55: invalid_url: https://python-soundfile.readthedocs.io/ : Not reachable: 403
clone/recipe/meta.yaml:34: host_section_needs_exact_pinnings: Linked libraries host should have exact version pinnings.
clone/recipe/meta.yaml:66: documentation_specifies_language: Use the generic link, not a language specific one

===== ERRORS =====

clone/recipe/meta.yaml:52: missing_pip_check: For pypi packages, pip check should be present in the test commands
clone/recipe/meta.yaml:23: patch_unnecessary: patch should not be in build when source/patches is not set
===== Final Report: =====
2 Errors and 4 Warnings were found

ryanskeith

LGTM.

psteyer added 3 commits September 25, 2024 19:12

pysoundfile 0.12.1

3ede200

adding about info

488e47e

adding flags to script line

207d826

skipping win and s390x

e4f7dea

removing win specific script line

feeb0d8

adding unvendoring patch

f29e09b

updating patch

7be0197

psteyer marked this pull request as ready for review September 27, 2024 20:30

psteyer self-assigned this Sep 27, 2024

JeanChristopheMorinPerso reviewed Sep 27, 2024

View reviewed changes

danpetry reviewed Oct 1, 2024

View reviewed changes

psteyer requested review from JeanChristopheMorinPerso and danpetry October 1, 2024 22:40

psteyer mentioned this pull request Oct 1, 2024

wfdb 4.1.2 ❄️ AnacondaRecipes/wfdb-feedstock#1

Open

adding staging channel

effecc1

This was referenced Oct 4, 2024

libopus 1.3 AnacondaRecipes/libopus-feedstock#1

Open

libsndfile 1.2.2 rebuild ❄️ AnacondaRecipes/libsndfile-feedstock#2

Open

ryanskeith approved these changes Oct 4, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pysoundfile 0.12.1 ❄️ #1

pysoundfile 0.12.1 ❄️ #1

psteyer commented Sep 26, 2024 •

edited

Loading

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 27, 2024

anaconda-pkg-build commented Sep 27, 2024

JeanChristopheMorinPerso Sep 27, 2024

danpetry Oct 1, 2024

psteyer Oct 1, 2024

danpetry Oct 2, 2024

JeanChristopheMorinPerso Sep 27, 2024

danpetry Oct 1, 2024

psteyer Oct 1, 2024

danpetry Oct 2, 2024

danpetry Oct 1, 2024

danpetry Oct 1, 2024

psteyer Oct 1, 2024

danpetry Oct 2, 2024

danpetry Oct 1, 2024

anaconda-pkg-build commented Oct 3, 2024

ryanskeith left a comment

pysoundfile 0.12.1 ❄️ #1

Are you sure you want to change the base?

pysoundfile 0.12.1 ❄️ #1

Conversation

psteyer commented Sep 26, 2024 • edited Loading

Links

Explanation of changes:

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 26, 2024

anaconda-pkg-build commented Sep 27, 2024

anaconda-pkg-build commented Sep 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anaconda-pkg-build commented Oct 3, 2024

ryanskeith left a comment

Choose a reason for hiding this comment

psteyer commented Sep 26, 2024 •

edited

Loading