Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always re-render prompt while navigating history #130

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amosbird
Copy link
Contributor

@amosbird amosbird commented Nov 9, 2021

@AmokHuginnsson
Copy link
Owner

AmokHuginnsson commented Nov 13, 2021

I need to think about more generic fix.
Proposed solution handles only very small subset of invalid behaviors when handling overlong lines.
It is quite possible that proper solution would go in completely different direction.
By proper solution I mean solution that handles multiline entries where there are more lines in entry than available lines on terminal and also some of those lines are (possibly much much) longer then width of the terminal.
In other words, proper solution would mean implementing a proper full screen text editor inside replxx.
I am not saying no to that and that is why I am hesitant to accept this pull request.

@amosbird
Copy link
Contributor Author

Ok.. Maybe we can have this proper implementation gradually and in the meantime providing some temporary workaround, as #127 is indeed common and recurrent, which is a little bit inconvenient to user experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants