[AMB-319] feat: send/receive bitcoin onchain #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
secondl1ght
changed the title
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
apotdevin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Branched off #81 so we can review/merge that PR first.NOTE: The library I am using to validate bitcoin addresses doesn't seem to recognise legacy addresses. I thought this might be OK for now since most people use the
bc...format, if we want to support legacy addresses we could relax the validation or try out a different package. This one seems good though and is isolated to a single function whereas some of the others are massive bitcoin JS libraries and may be overkill. One final option would be to try and write our own function to check the string.NOTE: I asked @bufo24 if send/receive onchain will work between Banco users, I only tested send/receive with an external partner because I wasn't sure if the backend was setup to handle onchain with Banco users or not. We should probably confirm this and test it before merging. I believe there were some changes made recently to allow for lightning swaps between Banco users so the same may be possible for onchain.