Issue #249 divisibility arbitrary percision #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
elpiel
commented
Feb 13, 2020
primitives/src/big_num.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl From<BigNum> for PrecisionU64 { |
There was a problem hiding this comment.
Should we use From with default of 0 or should we impl TryFrom and fail if this conversion cannot be done?
There was a problem hiding this comment.
TryFrom would be better as 0 may be magic :( I think error should be handled properly
Ivshti
reviewed
Feb 26, 2020
primitives/src/big_num.rs
Outdated
| /// DAI has precision of 18 decimals | ||
| /// For CPM we have 3 decimals precision, but that's for 1000 (3 decimals more) | ||
| /// This in terms means we need 18 - (3 + 3) = 12 decimals precision | ||
| pub const GLOBAL_MULTIPLIER: Multiplier = Multiplier(12); |
There was a problem hiding this comment.
why is this not 10**12 rather than 12? it would save you from having to do a pow operation
There was a problem hiding this comment.
Good idea! I will impl it.
…om:AdExNetwork/adex-validator-stack-rust into issue-249-divisibility-arbitrary-percision
… calculating it every time
|
Closing this in favor of the v5 Unified Precision of (8) #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #249