Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(showcase): add a readme to explain how to update the screenshots for visual testing #2489

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

fpaul-1A
Copy link
Contributor

Proposed change

Related issues

- No issue associated -

@fpaul-1A fpaul-1A requested a review from a team as a code owner November 19, 2024 14:41
@github-actions github-actions bot added documentation Improvements or additions to documentation project:@o3r/showcase labels Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (331f0da) to head (9dee21d).
Report is 8 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

sdo-1A
sdo-1A previously approved these changes Nov 19, 2024
kpanot
kpanot previously approved these changes Nov 19, 2024
@fpaul-1A fpaul-1A dismissed stale reviews from kpanot and sdo-1A via bf36a1c November 20, 2024 08:08
@fpaul-1A fpaul-1A force-pushed the doc/visual-test-screenshots-update branch from ab67f7e to bf36a1c Compare November 20, 2024 08:08
CONTRIBUTING.md Outdated Show resolved Hide resolved
@fpaul-1A fpaul-1A force-pushed the doc/visual-test-screenshots-update branch from bf36a1c to 9dee21d Compare November 20, 2024 08:30
@fpaul-1A fpaul-1A added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 6dc301c Nov 20, 2024
36 checks passed
@fpaul-1A fpaul-1A deleted the doc/visual-test-screenshots-update branch November 20, 2024 15:10
@@ -2,6 +2,9 @@
"ignorePatterns": [
{
"pattern": "^https?:\/\/.*"
},
{
"pattern": "^https?://(127.0.0.1|localhost)[:/].*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add the pattern here. As you can see, all urls that start with http are ignored already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation project:@o3r/showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants