Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint): fix test int #2483

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix(eslint): fix test int #2483

merged 1 commit into from
Nov 21, 2024

Conversation

matthieu-crouzet
Copy link
Contributor

No description provided.

@matthieu-crouzet matthieu-crouzet requested a review from a team as a code owner November 18, 2024 15:13
matthieu-crouzet
matthieu-crouzet commented Nov 18, 2024
View reviewed changes
apps/chrome-devtools/package.json
@@ -53,7 +53,7 @@
"chrome-webstore-upload": "^3.0.0",
"concurrently": "^8.0.0",
"cpy-cli": "^5.0.0",
"eslint": "^9.0.0",
Copy link
Contributor Author

@matthieu-crouzet matthieu-crouzet Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I limited the version to 9.14 because there is currently an issue on 9.15 typescript-eslint/typescript-eslint#10338

Issue is closed but version is not yet available

matthieu-crouzet
matthieu-crouzet commented Nov 18, 2024
View reviewed changes
...ges/@o3r/eslint-config-otter/schematics/ng-add/linter/templates/project/tsconfig.eslint.json
@@ -1,6 +1,6 @@
{
"extends": "./<%= projectTsConfig %>",
"include": [
"eslint*.config.mjs"
Copy link
Contributor Author

@matthieu-crouzet matthieu-crouzet Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback change made earlier by mistake

matthieu-crouzet
matthieu-crouzet commented Nov 18, 2024
View reviewed changes
packages/@o3r/eslint-config-otter/package.json
"@angular/compiler": "~18.2.0",
"@o3r/eslint-plugin": "workspace:^",
"@o3r/schematics": "workspace:^",
"@schematics/angular": "~18.2.0",
"@stylistic/eslint-plugin-ts": "^2.7.0",
"angular-eslint": "~18.3.0",
"eslint": "^8.57.0 || ^9.0.0",
"@typescript-eslint/eslint-plugin": "^7.14.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fallback versions changes to not introduce breaking changes

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 18, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 093d50d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@matthieu-crouzet matthieu-crouzet force-pushed the fix/eslint-test-int branch 2 times, most recently from 4549283 to d3c3572 Compare November 19, 2024 08:59
sdo-1A
sdo-1A previously approved these changes Nov 19, 2024
View reviewed changes
fpaul-1A
fpaul-1A previously approved these changes Nov 19, 2024
View reviewed changes
@matthieu-crouzet matthieu-crouzet dismissed stale reviews from fpaul-1A and sdo-1A November 20, 2024 09:48

comments fixed

@matthieu-crouzet matthieu-crouzet merged commit 68bc538 into feat/migrate-eslint-9-flat-config Nov 21, 2024
2 checks passed
@matthieu-crouzet matthieu-crouzet deleted the fix/eslint-test-int branch November 21, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpaulve-1A cpaulve-1A cpaulve-1A approved these changes

@fpaul-1A fpaul-1A fpaul-1A approved these changes

@kpanot kpanot kpanot approved these changes

@sdo-1A sdo-1A sdo-1A left review comments

Assignees
No one assigned
Labels
bug Something isn't working project:@ama-sdk/client-angular project:@ama-sdk/client-beacon project:@ama-sdk/client-fetch project:@ama-sdk/core project:@ama-sdk/create project:@ama-sdk/schematics project:@ama-sdk/swagger-builder project:@ama-terasu/cli project:@ama-terasu/core project:@ama-terasu/schematics project:audit-gh-action project:cascading-gh-action project:get-npm-tag-gh-action project:new-version-gh-action project:@o3r/amaterasu-api-spec project:@o3r/amaterasu-dodo project:@o3r/amaterasu-otter project:@o3r/amaterasu-sdk project:@o3r/analytics project:@o3r/apis-manager project:@o3r/application project:@o3r/artifactory-tools project:@o3r/azure-tools project:@o3r/build-helpers project:@o3r/chrome-devtools project:@o3r/components project:@o3r/configuration project:@o3r/core project:@o3r/create project:@o3r/design project:@o3r/dev-tools project:@o3r/dynamic-content project:@o3r/eslint-config project:@o3r/eslint-config-otter project:@o3r/eslint-plugin project:@o3r/extractors project:@o3r/forms project:@o3r/github-cascading-app project:@o3r/localization project:@o3r/logger project:@o3r/mobile project:@o3r/new-version project:@o3r/pipeline project:@o3r/routing project:@o3r/rules-engine project:@o3r/schematics project:@o3r/showcase project:@o3r/store-sync project:@o3r/storybook project:@o3r/stylelint-plugin project:@o3r/styling project:@o3r/telemetry project:@o3r/test-helpers project:@o3r/testing project:@o3r/third-party project:@o3r/workspace project:@o3r-training/showcase-sdk project:@o3r-training/training-tools project:otter-devtools project:release-gh-action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthieu-crouzet @kpanot @fpaul-1A @cpaulve-1A @sdo-1A