Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): lock file maintenance #2438

Merged
merged 2 commits into from
Nov 12, 2024
Merged

chore(deps): lock file maintenance #2438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
50a7e5e
chore(deps): lock file maintenance
renovate[bot] Nov 11, 2024
87bf98c
fix(artifactory-tools): added missing explicit type
kpanot Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@o3r/artifactory-tools/src/cli/pr-artifact-cleaner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const winstonOptions = {
info.message = JSON.stringify(info.message, null, 3);
}

return info.message;
return info.message as string;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return info.message as string;
return info.message.toString();

no ?

Copy link
Contributor

@kpanot kpanot Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, it is of type unknown and adding toString() would be a code change and would be less correct (as it is already a string flagged as unknown

})
)
}
Expand Down
2 changes: 1 addition & 1 deletion packages/@o3r/dev-tools/src/cli/aql-artifact-cleaner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const winstonOptions = {
info.message = JSON.stringify(info.message, null, 3);
}

return info.message;
return info.message as string;
})
)
}
Expand Down
Loading
Loading