Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): add sorting way based on regexps #2379

Merged
merged 1 commit into from
Oct 31, 2024

feat(design): add sorting way based on regexps

7034f66
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

feat(design): add sorting way based on regexps #2379

feat(design): add sorting way based on regexps
7034f66
Select commit
Loading
Failed to load commit list.
GitHub Actions / UT Tests report-windows-latest succeeded Oct 31, 2024 in 1s

120 passed, 0 failed and 0 skipped

Tests passed successfully

Report Passed Failed Skipped Time
apps/showcase/dist-test/ut-report.xml 27✅ 39s
apps/vscode-extension/dist-test/ut-report.xml 1✅ 926ms
packages/@o3r/design/dist-test/ut-report.xml 92✅ 17s

✅ apps/showcase/dist-test/ut-report.xml

27 tests were completed in 39s with 27 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
AppComponent 1✅ 4s
BasicPresComponent 1✅ 2s
ComponentReplacementComponent 1✅ 3s
ComponentReplacementPresComponent 1✅ 15s
ConfigurationComponent 1✅ 4s
ConfigurationPresComponent 1✅ 2s
CopyTextPresComponent 1✅ 548ms
DatePickerHebrewInputPresComponent 1✅ 2s
DatePickerInputPresComponent 1✅ 2s
DesignTokenComponent 1✅ 3s
DesignTokenPresComponent 1✅ 2s
DynamicContentComponent 1✅ 3s
DynamicContentPresComponent 1✅ 2s
HomeComponent 1✅ 2s
InPageNavPresComponent 1✅ 1s
LocalizationComponent 1✅ 4s
LocalizationPresComponent 1✅ 3s
OtterPickerPresComponent 1✅ 1s
PlaceholderComponent 1✅ 3s
PlaceholderPresComponent 1✅ 2s
RulesEngineComponent 1✅ 20s
RulesEnginePresComponent 1✅ 16s
RunAppLocallyComponent 1✅ 2s
ScrollBackTopPresComponent 1✅ 866ms
SdkComponent 1✅ 3s
SdkPresComponent 1✅ 2s
SidenavPresComponent 1✅ 1s

✅ AppComponent

AppComponent should create the app
  ✅ AppComponent should create the app

✅ BasicPresComponent

BasicPresComponent should create
  ✅ BasicPresComponent should create

✅ ComponentReplacementComponent

ComponentReplacementComponent should create
  ✅ ComponentReplacementComponent should create

✅ ComponentReplacementPresComponent

ComponentReplacementPresComponent should create
  ✅ ComponentReplacementPresComponent should create

✅ ConfigurationComponent

ConfigurationComponent should create
  ✅ ConfigurationComponent should create

✅ ConfigurationPresComponent

ConfigurationPresComponent should create
  ✅ ConfigurationPresComponent should create

✅ CopyTextPresComponent

CopyTextPresComponent should create
  ✅ CopyTextPresComponent should create

✅ DatePickerHebrewInputPresComponent

DatePickerHebrewInputPresComponent should create
  ✅ DatePickerHebrewInputPresComponent should create

✅ DatePickerInputPresComponent

DatePickerInputPresComponent should create
  ✅ DatePickerInputPresComponent should create

✅ DesignTokenComponent

DesignTokenComponent should create
  ✅ DesignTokenComponent should create

✅ DesignTokenPresComponent

DesignTokenPresComponent should create
  ✅ DesignTokenPresComponent should create

✅ DynamicContentComponent

DynamicContentComponent should create
  ✅ DynamicContentComponent should create

✅ DynamicContentPresComponent

DynamicContentPresComponent should create
  ✅ DynamicContentPresComponent should create

✅ HomeComponent

HomeComponent should create
  ✅ HomeComponent should create

✅ InPageNavPresComponent

InPageNavPresComponent should create
  ✅ InPageNavPresComponent should create

✅ LocalizationComponent

LocalizationComponent should create
  ✅ LocalizationComponent should create

✅ LocalizationPresComponent

LocalizationPresComponent should create
  ✅ LocalizationPresComponent should create

✅ OtterPickerPresComponent

OtterPickerPresComponent should create
  ✅ OtterPickerPresComponent should create

✅ PlaceholderComponent

PlaceholderComponent should create
  ✅ PlaceholderComponent should create

✅ PlaceholderPresComponent

PlaceholderPresComponent should create
  ✅ PlaceholderPresComponent should create

✅ RulesEngineComponent

RulesEngineComponent should create
  ✅ RulesEngineComponent should create

✅ RulesEnginePresComponent

RulesEnginePresComponent should create
  ✅ RulesEnginePresComponent should create

✅ RunAppLocallyComponent

RunAppLocallyComponent should create
  ✅ RunAppLocallyComponent should create

✅ ScrollBackTopPresComponent

ScrollBackTopPresComponent should create
  ✅ ScrollBackTopPresComponent should create

✅ SdkComponent

SdkComponent should create
  ✅ SdkComponent should create

✅ SdkPresComponent

SdkPresComponent should create
  ✅ SdkPresComponent should create

✅ SidenavPresComponent

SidenavPresComponent should create
  ✅ SidenavPresComponent should create

✅ apps/vscode-extension/dist-test/ut-report.xml

1 tests were completed in 926ms with 1 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
undefined 1✅ 779ms

✅ undefined

 should be removed as soon as we have one test in this package
  ✅ should be removed as soon as we have one test in this package

✅ packages/@o3r/design/dist-test/ut-report.xml

92 tests were completed in 17s with 92 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
Add Design Token to component 3✅ 10s
Design Token generator 6✅ 3s
Design Token Parser 13✅ 2s
Design Token Renderer 14✅ 3s
Extract Token schematic 3✅ 11s
getCssStyleContentUpdater 3✅ 212ms
getCssTokenValueRenderer 7✅ 452ms
getDesignTokenStyleContentUpdater 2✅ 460ms
getDesignTokenTokenDefinitionRenderer 5✅ 334ms
getDesignTokenTokenValueRenderer 3✅ 253ms
getJsonSchemaStyleContentUpdater 1✅ 234ms
getJsonSchemaTokenValueRenderer 2✅ 359ms
getMetadataStyleContentUpdater 1✅ 249ms
getMetadataTokenDefinitionRenderer 4✅ 673ms
getMetadataTokenDefinitionRenderer 2✅ 293ms
getMetadataTokenDefinitionRenderer 3✅ 283ms
getMetadataTokenValueRenderer 3✅ 302ms
getSassTokenDefinitionRenderer 3✅ 282ms
getSassTokenValueRenderer 7✅ 371ms
isO3rPrivateVariable 3✅ 242ms
mergeDesignTokenTemplates function 2✅ 616ms
ng-add 2✅ 11s

✅ Add Design Token to component

Add Design Token to component should create the design token file
  ✅ Add Design Token to component should create the design token file
Add Design Token to component should create the design token file and target styling file
  ✅ Add Design Token to component should create the design token file and target styling file
Add Design Token to component should create the design token file with correct name
  ✅ Add Design Token to component should create the design token file with correct name

✅ Design Token generator

Design Token generator CSS renderer should render variable in CSS
  ✅ Design Token generator CSS renderer should render variable in CSS
Design Token generator CSS renderer should render variable with important flag
  ✅ Design Token generator CSS renderer should render variable with important flag
Design Token generator CSS renderer should render variable with prefix
  ✅ Design Token generator CSS renderer should render variable with prefix
Design Token generator CSS renderer should render variable in existing CSS
  ✅ Design Token generator CSS renderer should render variable in existing CSS
Design Token generator CSS renderer should render private variable to sass if requested
  ✅ Design Token generator CSS renderer should render private variable to sass if requested
Design Token generator Metadata Renderer should render valid metadata
  ✅ Design Token generator Metadata Renderer should render valid metadata

✅ Design Token Parser

Design Token Parser parseDesignToken should support single root key
  ✅ Design Token Parser parseDesignToken should support single root key
Design Token Parser parseDesignToken should generate a simple type variable
  ✅ Design Token Parser parseDesignToken should generate a simple type variable
Design Token Parser parseDesignToken should generate an alias variable
  ✅ Design Token Parser parseDesignToken should generate an alias variable
Design Token Parser parseDesignToken with template set should generate a variable with template
  ✅ Design Token Parser parseDesignToken with template set should generate a variable with template
Design Token Parser parseDesignToken with template set should generate a variable with template override
  ✅ Design Token Parser parseDesignToken with template set should generate a variable with template override
Design Token Parser parseDesignToken with template set should generate a variable with template when the token matches star
  ✅ Design Token Parser parseDesignToken with template set should generate a variable with template when the token matches star
Design Token Parser parseDesignToken should generate a complex variable
  ✅ Design Token Parser parseDesignToken should generate a complex variable
Design Token Parser parseDesignToken should generate correctly the gradient
  ✅ Design Token Parser parseDesignToken should generate correctly the gradient
Design Token Parser parseDesignToken should generate correctly the shadow with single parameter
  ✅ Design Token Parser parseDesignToken should generate correctly the shadow with single parameter
Design Token Parser parseDesignToken should generate correctly the shadow with multiple parameter
  ✅ Design Token Parser parseDesignToken should generate correctly the shadow with multiple parameter
Design Token Parser parseDesignTokenFile should read the file according to the reader
  ✅ Design Token Parser parseDesignTokenFile should read the file according to the reader
Design Token Parser parseDesignTokenFile should propagate context object
  ✅ Design Token Parser parseDesignTokenFile should propagate context object
Design Token Parser parseDesignTokenFile should throw if invalid JSON Token
  ✅ Design Token Parser parseDesignTokenFile should throw if invalid JSON Token

✅ Design Token Renderer

Design Token Renderer computeFileToUpdatePath should return default file if not specified
  ✅ Design Token Renderer computeFileToUpdatePath should return default file if not specified
Design Token Renderer computeFileToUpdatePath should return file specified by the token
  ✅ Design Token Renderer computeFileToUpdatePath should return file specified by the token
Design Token Renderer getFileToUpdatePath should return default file if not specified
  ✅ Design Token Renderer getFileToUpdatePath should return default file if not specified
Design Token Renderer getFileToUpdatePath should return file specified by the token
  ✅ Design Token Renderer getFileToUpdatePath should return file specified by the token
Design Token Renderer renderDesignTokens should call the process for all variables
  ✅ Design Token Renderer renderDesignTokens should call the process for all variables
Design Token Renderer renderDesignTokens should update all the files
  ✅ Design Token Renderer renderDesignTokens should update all the files
Design Token Renderer renderDesignTokens the transformers sorting by name should sort variable by name per default
  ✅ Design Token Renderer renderDesignTokens the transformers sorting by name should sort variable by name per default
Design Token Renderer renderDesignTokens the transformers sorting by name should sort variable based on option
  ✅ Design Token Renderer renderDesignTokens the transformers sorting by name should sort variable based on option
Design Token Renderer renderDesignTokens the transformers sorting by name should execute the transform functions in given order
  ✅ Design Token Renderer renderDesignTokens the transformers sorting by name should execute the transform functions in given order
Design Token Renderer getTokenSorterByRef should sort properly variables with multiple refs
  ✅ Design Token Renderer getTokenSorterByRef should sort properly variables with multiple refs
Design Token Renderer getTokenSorterFromRegExpList should sort properly based on regExps
  ✅ Design Token Renderer getTokenSorterFromRegExpList should sort properly based on regExps
Design Token Renderer getTokenSorterFromRegExpList should not sort unmatched tokens
  ✅ Design Token Renderer getTokenSorterFromRegExpList should not sort unmatched tokens
Design Token Renderer getTokenSorterFromRegExpList should be correctly applied
  ✅ Design Token Renderer getTokenSorterFromRegExpList should be correctly applied
Design Token Renderer getTokenSorterByName should sort properly variables with grade number
  ✅ Design Token Renderer getTokenSorterByName should sort properly variables with grade number

✅ Extract Token schematic

Extract Token schematic should correctly extract the Design Token
  ✅ Extract Token schematic should correctly extract the Design Token
Extract Token schematic should extract the Design Token with right flatten level
  ✅ Extract Token schematic should extract the Design Token with right flatten level
Extract Token schematic should Update the original file
  ✅ Extract Token schematic should Update the original file

✅ getCssStyleContentUpdater

getCssStyleContentUpdater should render CSS Values
  ✅ getCssStyleContentUpdater should render CSS Values
getCssStyleContentUpdater should add tags to new file
  ✅ getCssStyleContentUpdater should add tags to new file
getCssStyleContentUpdater should only update within tag part
  ✅ getCssStyleContentUpdater should only update within tag part

✅ getCssTokenValueRenderer

getCssTokenValueRenderer should render valid CSS value
  ✅ getCssTokenValueRenderer should render valid CSS value
getCssTokenValueRenderer should render valid CSS var
  ✅ getCssTokenValueRenderer should render valid CSS var
getCssTokenValueRenderer should render valid CSS var of not print value
  ✅ getCssTokenValueRenderer should render valid CSS var of not print value
getCssTokenValueRenderer should render invalid reference and raise warning
  ✅ getCssTokenValueRenderer should render invalid reference and raise warning
getCssTokenValueRenderer with extension value override should not override non-numeric value
  ✅ getCssTokenValueRenderer with extension value override should not override non-numeric value
getCssTokenValueRenderer with extension value override should override numeric value and add unit
  ✅ getCssTokenValueRenderer with extension value override should override numeric value and add unit
getCssTokenValueRenderer with extension value override should override numeric value and unit
  ✅ getCssTokenValueRenderer with extension value override should override numeric value and unit

✅ getDesignTokenStyleContentUpdater

getDesignTokenStyleContentUpdater should render valid JSON object
  ✅ getDesignTokenStyleContentUpdater should render valid JSON object
getDesignTokenStyleContentUpdater should merge node
  ✅ getDesignTokenStyleContentUpdater should merge node

✅ getDesignTokenTokenDefinitionRenderer

getDesignTokenTokenDefinitionRenderer should rely on given tokenValueRenderer
  ✅ getDesignTokenTokenDefinitionRenderer should rely on given tokenValueRenderer
getDesignTokenTokenDefinitionRenderer should render valid JSON object
  ✅ getDesignTokenTokenDefinitionRenderer should render valid JSON object
getDesignTokenTokenDefinitionRenderer should render deep object without keyLevel
  ✅ getDesignTokenTokenDefinitionRenderer should render deep object without keyLevel
getDesignTokenTokenDefinitionRenderer should render deep object with keyLevel
  ✅ getDesignTokenTokenDefinitionRenderer should render deep object with keyLevel
getDesignTokenTokenDefinitionRenderer should render deep object with keyLevel overflow
  ✅ getDesignTokenTokenDefinitionRenderer should render deep object with keyLevel overflow

✅ getDesignTokenTokenValueRenderer

getDesignTokenTokenValueRenderer should render valid JSON object
  ✅ getDesignTokenTokenValueRenderer should render valid JSON object
getDesignTokenTokenValueRenderer should render token with original value
  ✅ getDesignTokenTokenValueRenderer should render token with original value
getDesignTokenTokenValueRenderer should inherit of parent properties
  ✅ getDesignTokenTokenValueRenderer should inherit of parent properties

✅ getJsonSchemaStyleContentUpdater

getJsonSchemaStyleContentUpdater should render valid JSON object
  ✅ getJsonSchemaStyleContentUpdater should render valid JSON object

✅ getJsonSchemaTokenValueRenderer

getJsonSchemaTokenValueRenderer should rely on given UrlRenderer
  ✅ getJsonSchemaTokenValueRenderer should rely on given UrlRenderer
getJsonSchemaTokenValueRenderer should render valid JSON object
  ✅ getJsonSchemaTokenValueRenderer should render valid JSON object

✅ getMetadataStyleContentUpdater

getMetadataStyleContentUpdater should render valid JSON object
  ✅ getMetadataStyleContentUpdater should render valid JSON object

✅ getMetadataTokenDefinitionRenderer

getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
  ✅ getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
getMetadataTokenDefinitionRenderer in case of private variable should render it per default
  ✅ getMetadataTokenDefinitionRenderer in case of private variable should render it per default
getMetadataTokenDefinitionRenderer in case of private variable should not render it when required
  ✅ getMetadataTokenDefinitionRenderer in case of private variable should not render it when required
getMetadataTokenDefinitionRenderer should render valid JSON object
  ✅ getMetadataTokenDefinitionRenderer should render valid JSON object

✅ getMetadataTokenDefinitionRenderer

getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
  ✅ getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
getMetadataTokenDefinitionRenderer should render valid JSON object
  ✅ getMetadataTokenDefinitionRenderer should render valid JSON object

✅ getMetadataTokenDefinitionRenderer

getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
  ✅ getMetadataTokenDefinitionRenderer should rely on given tokenValueRenderer
getMetadataTokenDefinitionRenderer should use private renderer for private variable
  ✅ getMetadataTokenDefinitionRenderer should use private renderer for private variable
getMetadataTokenDefinitionRenderer should enforce reference when expecting override
  ✅ getMetadataTokenDefinitionRenderer should enforce reference when expecting override

✅ getMetadataTokenValueRenderer

getMetadataTokenValueRenderer should rely on given cssValueRenderer
  ✅ getMetadataTokenValueRenderer should rely on given cssValueRenderer
getMetadataTokenValueRenderer should render valid JSON object
  ✅ getMetadataTokenValueRenderer should render valid JSON object
getMetadataTokenValueRenderer should correctly remove private variables from generation
  ✅ getMetadataTokenValueRenderer should correctly remove private variables from generation

✅ getSassTokenDefinitionRenderer

getSassTokenDefinitionRenderer should rely on given tokenValueRenderer
  ✅ getSassTokenDefinitionRenderer should rely on given tokenValueRenderer
getSassTokenDefinitionRenderer should append default when expecting override
  ✅ getSassTokenDefinitionRenderer should append default when expecting override
getSassTokenDefinitionRenderer should prefix private variable
  ✅ getSassTokenDefinitionRenderer should prefix private variable

✅ getSassTokenValueRenderer

getSassTokenValueRenderer should render valid Scss value
  ✅ getSassTokenValueRenderer should render valid Scss value
getSassTokenValueRenderer should render valid Scss var
  ✅ getSassTokenValueRenderer should render valid Scss var
getSassTokenValueRenderer should render valid Scss var and not print value
  ✅ getSassTokenValueRenderer should render valid Scss var and not print value
getSassTokenValueRenderer should render invalid reference and raise warning
  ✅ getSassTokenValueRenderer should render invalid reference and raise warning
getSassTokenValueRenderer with extension value override should not override non-numeric value
  ✅ getSassTokenValueRenderer with extension value override should not override non-numeric value
getSassTokenValueRenderer with extension value override should override numeric value and add unit
  ✅ getSassTokenValueRenderer with extension value override should override numeric value and add unit
getSassTokenValueRenderer with extension value override should override numeric value and unit
  ✅ getSassTokenValueRenderer with extension value override should override numeric value and unit

✅ isO3rPrivateVariable

isO3rPrivateVariable should determine the variable as ignored
  ✅ isO3rPrivateVariable should determine the variable as ignored
isO3rPrivateVariable should determine the variable as not ignored
  ✅ isO3rPrivateVariable should determine the variable as not ignored
isO3rPrivateVariable should determine the alias variable as not ignored
  ✅ isO3rPrivateVariable should determine the alias variable as not ignored

✅ mergeDesignTokenTemplates function

mergeDesignTokenTemplates function should merge object
  ✅ mergeDesignTokenTemplates function should merge object
mergeDesignTokenTemplates function should override data in case on config
  ✅ mergeDesignTokenTemplates function should override data in case on config

✅ ng-add

ng-add should generate the template files
  ✅ ng-add should generate the template files
ng-add should import theming file in styles.scss
  ✅ ng-add should import theming file in styles.scss
View more details on GitHub Actions