Skip to content

Commit

Permalink
fix(eslint): fix remaining rules after team discussion (#2426)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthieu-crouzet authored Nov 8, 2024
2 parents 1416271 + 59694d8 commit f430b39
Show file tree
Hide file tree
Showing 1,468 changed files with 6,270 additions and 6,291 deletions.
4 changes: 2 additions & 2 deletions apps/chrome-devtools/eslint.local.config.mjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {
dirname
dirname,
} from 'node:path';
import {
fileURLToPath
fileURLToPath,
} from 'node:url';
import globals from 'globals';

Expand Down
4 changes: 2 additions & 2 deletions apps/chrome-devtools/scripts/publish-to-market.mjs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {
createWriteStream
createWriteStream,
} from 'node:fs';
import {
resolve
resolve,
} from 'node:path';
import * as url from 'node:url';
import archiver from 'archiver';
Expand Down
4 changes: 2 additions & 2 deletions apps/chrome-devtools/src/app-components.main.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {
bootstrapApplication
bootstrapApplication,
} from '@angular/platform-browser';
import {
AppComponent
AppComponent,
} from './app-components/app.component';

// eslint-disable-next-line no-console -- Generated by Angular
Expand Down
26 changes: 13 additions & 13 deletions apps/chrome-devtools/src/app-components/app.component.ts
Original file line number Diff line number Diff line change
@@ -1,52 +1,52 @@
import {
AsyncPipe
AsyncPipe,
} from '@angular/common';
import {
ChangeDetectionStrategy,
ChangeDetectorRef,
Component
Component,
} from '@angular/core';
import {
getAnalyticEvents as devkitGetAnalyticEvents,
getTranslations as devkitGetTranslations,
getAnalyticEventsRec,
getTranslationsRec,
Ng,
OtterLikeComponentInfo
OtterLikeComponentInfo,
} from '@o3r/components';
import type {
ConfigurationModel
ConfigurationModel,
} from '@o3r/configuration';
import {
otterComponentInfoPropertyName
otterComponentInfoPropertyName,
} from '@o3r/core';
import type {
OtterComponentInfo
OtterComponentInfo,
} from '@o3r/core';
import type {
RulesetExecutionDebug
RulesetExecutionDebug,
} from '@o3r/rules-engine';
import {
BehaviorSubject,
combineLatest,
Observable
Observable,
} from 'rxjs';
import {
filter,
map,
startWith
startWith,
} from 'rxjs/operators';
import {
AppConnectionComponent
AppConnectionComponent,
} from '../components/app-connection/app-connection.component';
import {
OtterComponentComponent
OtterComponentComponent,
} from '../components/otter-component/otter-component.component';
import {
ChromeExtensionConnectionService
ChromeExtensionConnectionService,
} from '../services/connection.service';
import {
RulesetHistoryService
RulesetHistoryService,
} from '../services/ruleset-history.service';

declare namespace window {
Expand Down
4 changes: 2 additions & 2 deletions apps/chrome-devtools/src/app-devtools.main.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {
bootstrapApplication
bootstrapApplication,
} from '@angular/platform-browser';
import {
AppComponent
AppComponent,
} from './app-devtools/app.component';

// eslint-disable-next-line no-console -- Generated by Angular
Expand Down
38 changes: 19 additions & 19 deletions apps/chrome-devtools/src/app-devtools/app.component.ts
Original file line number Diff line number Diff line change
@@ -1,70 +1,70 @@
import {
AsyncPipe,
JsonPipe
JsonPipe,
} from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
computed,
effect,
inject
inject,
} from '@angular/core';
import {
takeUntilDestroyed,
toSignal
toSignal,
} from '@angular/core/rxjs-interop';
import {
FormBuilder,
FormControl,
FormsModule,
ReactiveFormsModule
ReactiveFormsModule,
} from '@angular/forms';
import {
DfSelectModule,
DfTooltipModule
DfTooltipModule,
} from '@design-factory/design-factory';
import {
NgbNavModule
NgbNavModule,
} from '@ng-bootstrap/ng-bootstrap';
import {
RulesetHistoryPresModule
RulesetHistoryPresModule,
} from '@o3r/rules-engine';
import {
AppConnectionComponent
AppConnectionComponent,
} from '../components/app-connection/app-connection.component';
import type {
State
State,
} from '../extension/interface';
import {
StateService
StateService,
} from '../services';
import {
ChromeExtensionConnectionService,
isApplicationInformationMessage
isApplicationInformationMessage,
} from '../services/connection.service';
import {
RulesetHistoryService
RulesetHistoryService,
} from '../services/ruleset-history.service';
import {
ComponentPanelPresComponent
ComponentPanelPresComponent,
} from './component-panel/component-panel-pres.component';
import {
ConfigPanelPresComponent
ConfigPanelPresComponent,
} from './config-panel/config-panel-pres.component';
import {
DebugPanelPresComponent
DebugPanelPresComponent,
} from './debug-panel/debug-panel-pres.component';
import {
DebugPanelService
DebugPanelService,
} from './debug-panel/debug-panel.service';
import {
LocalizationPanelPresComponent
LocalizationPanelPresComponent,
} from './localization-panel/localization-panel-pres.component';
import {
StatePanelComponent
StatePanelComponent,
} from './state-panel/state-panel.component';
import {
ThemingPanelPresComponent
ThemingPanelPresComponent,
} from './theming-panel/theming-panel-pres.component';

@Component({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,44 +1,44 @@
import {
AsyncPipe
AsyncPipe,
} from '@angular/common';
import {
ChangeDetectionStrategy,
ChangeDetectorRef,
Component,
OnDestroy,
ViewEncapsulation
ViewEncapsulation,
} from '@angular/core';
import type {
IsComponentSelectionAvailableMessage,
OtterLikeComponentInfo
OtterLikeComponentInfo,
} from '@o3r/components';
import {
ConfigurationModel
ConfigurationModel,
} from '@o3r/configuration';
import type {
RulesetExecutionDebug
RulesetExecutionDebug,
} from '@o3r/rules-engine';
import {
BehaviorSubject,
combineLatest,
Observable,
Subscription
Subscription,
} from 'rxjs';
import {
filter,
map,
shareReplay,
startWith
startWith,
} from 'rxjs/operators';
import {
OtterComponentComponent
OtterComponentComponent,
} from '../../components/otter-component/otter-component.component';
import {
ChromeExtensionConnectionService,
isSelectedComponentInfoMessage
isSelectedComponentInfoMessage,
} from '../../services/connection.service';
import {
RulesetHistoryService
RulesetHistoryService,
} from '../../services/ruleset-history.service';

@Component({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,38 +1,38 @@
import {
AsyncPipe
AsyncPipe,
} from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
ViewEncapsulation
ViewEncapsulation,
} from '@angular/core';
import {
FormControl,
FormGroup,
FormsModule,
ReactiveFormsModule
ReactiveFormsModule,
} from '@angular/forms';
import {
NgbAccordionModule
NgbAccordionModule,
} from '@ng-bootstrap/ng-bootstrap';
import {
ConfigurationModel
ConfigurationModel,
} from '@o3r/configuration';
import {
combineLatest,
Observable
Observable,
} from 'rxjs';
import {
map,
startWith
startWith,
} from 'rxjs/operators';
import {
ConfigFormComponent
ConfigFormComponent,
} from '../../components/config-form/config-form.component';
import {
ChromeExtensionConnectionService,
filterAndMapMessage,
isConfigurationsMessage
isConfigurationsMessage,
} from '../../services/connection.service';

@Component({
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
import {
AsyncPipe,
TitleCasePipe
TitleCasePipe,
} from '@angular/common';
import {
ChangeDetectionStrategy,
Component,
type OnDestroy,
ViewEncapsulation
ViewEncapsulation,
} from '@angular/core';
import {
FormControl,
FormGroup,
FormsModule,
ReactiveFormsModule
ReactiveFormsModule,
} from '@angular/forms';
import {
Subscription
Subscription,
} from 'rxjs';
import {
ChromeExtensionConnectionService
ChromeExtensionConnectionService,
} from '../../services/connection.service';
import {
DebugPanelService
DebugPanelService,
} from './debug-panel.service';

type PlaceholderMode = 'normal' | 'debug' | 'pending';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {
Injectable
Injectable,
} from '@angular/core';
import type {
ApplicationInformationContentMessage
ApplicationInformationContentMessage,
} from '@o3r/application';
import {
ReplaySubject
ReplaySubject,
} from 'rxjs';

export interface ExtendedApplicationInformation {
Expand Down
Loading

0 comments on commit f430b39

Please sign in to comment.