Skip to content

Commit

Permalink
fix(accessibility): import the full module to have all accessibilitie…
Browse files Browse the repository at this point in the history
…s features (#2382)

## Proposed change

<!--
Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
-->

## Related issues

<!--
Please make sure to follow the [contribution
guidelines](https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md)
-->

*- No issue associated -*

<!-- * 🐛 Fix #issue -->
<!-- * 🐛 Fix resolves #issue -->
<!-- * 🚀 Feature #issue -->
<!-- * 🚀 Feature resolves #issue -->
<!-- * :octocat: Pull Request #issue -->
  • Loading branch information
matthieu-crouzet authored Oct 31, 2024
2 parents 8b7d251 + 569f3d6 commit f0a1ebe
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 10 deletions.
8 changes: 2 additions & 6 deletions apps/showcase/src/app/rules-engine/rules-engine.component.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { AsyncPipe } from '@angular/common';
import { AfterViewInit, ChangeDetectionStrategy, Component, inject, QueryList, ViewChildren, ViewEncapsulation } from '@angular/core';
import { RouterModule } from '@angular/router';
import { NgbNav, NgbNavContent, NgbNavItem, NgbNavLink, NgbNavOutlet } from '@ng-bootstrap/ng-bootstrap';
import { NgbNavModule } from '@ng-bootstrap/ng-bootstrap';
import { ApplicationDevtoolsModule } from '@o3r/application';
import { ComponentsDevtoolsModule } from '@o3r/components';
import { ConfigOverrideStoreModule, ConfigurationBaseServiceModule, ConfigurationDevtoolsModule } from '@o3r/configuration';
Expand Down Expand Up @@ -54,11 +54,7 @@ import { duringSummer } from '../../operators/index';
CopyTextPresComponent,
RouterModule,
IN_PAGE_NAV_PRES_DIRECTIVES,
NgbNav,
NgbNavItem,
NgbNavLink,
NgbNavContent,
NgbNavOutlet,
NgbNavModule,
AsyncPipe
],
templateUrl: './rules-engine.template.html',
Expand Down
8 changes: 4 additions & 4 deletions apps/showcase/src/app/rules-engine/rules-engine.template.html
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ <h2 id="rules-engine-example">Example</h2>
</p>
<a href="https://github.com/AmadeusITGroup/otter/blob/main/apps/showcase/src/components/showcase/rules-engine" target="_blank" rel="noopener">Source code</a>
<ul ngbNav #nav="ngbNav" class="nav nav-tabs mt-3">
<li ngbNavItem class="nav-item" role="presentation">
<li ngbNavItem class="nav-item">
<a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'configuration'" (click)="activateRuleTab('configuration')">Configuration rule</a>
<ng-template ngbNavContent>
<p>
Expand All @@ -45,7 +45,7 @@ <h2 id="rules-engine-example">Example</h2>
<o3r-copy-text-pres language="json" [text]="newYorkAvailableRule"></o3r-copy-text-pres>
</ng-template>
</li>
<li ngbNavItem class="nav-item" role="presentation">
<li ngbNavItem class="nav-item">
<a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'localization'" (click)="activateRuleTab('localization')">Localization rule</a>
<ng-template ngbNavContent>
<p>
Expand All @@ -54,7 +54,7 @@ <h2 id="rules-engine-example">Example</h2>
<o3r-copy-text-pres language="json" [text]="helloNewYorkRule"></o3r-copy-text-pres>
</ng-template>
</li>
<li ngbNavItem class="nav-item" role="presentation">
<li ngbNavItem class="nav-item">
<a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'dynamic-content'" (click)="activateRuleTab('dynamic-content')">Dynamic content rule</a>
<ng-template ngbNavContent>
<p>
Expand All @@ -65,7 +65,7 @@ <h2 id="rules-engine-example">Example</h2>
<o3r-copy-text-pres language="json" [text]="summerOtterRule"></o3r-copy-text-pres>
</ng-template>
</li>
<li ngbNavItem class="nav-item" role="presentation">
<li ngbNavItem class="nav-item">
<a ngbNavLink class="nav-link" [class.active]="activeRuleTab === 'operator-fact'" (click)="activateRuleTab('operator-fact')">Operator fact</a>
<ng-template ngbNavContent>
<p>
Expand Down

0 comments on commit f0a1ebe

Please sign in to comment.