Skip to content

Commit

Permalink
fix: missing types when linting showcase-sdk (#1309)
Browse files Browse the repository at this point in the history
## Proposed change

When linting showcase-sdk, if the build of dependent packages was not
done (which is the case in CI), types of dependent packages are
interpreted by typescript as `any` because the tsconfig in showcase-sdk
overrides paths defined in the root of the repository and, as a
consequence, typescript does not find the source files defining the
types.

## Related issues

This PR supersedes #1306
  • Loading branch information
divdavem authored Feb 1, 2024
2 parents 3850282 + 0ab0532 commit e330a46
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,6 @@
"composite": true,
"declaration": true,
"declarationMap": false,
"rootDir": "./src",
"baseUrl": ".",
"paths": {
"<% if (projectName) { %>@<%=projectName%>/<% } %><%=projectPackageName%>/helpers/*": [
"./src/helpers/*"
],
"<% if (projectName) { %>@<%=projectName%>/<% } %><%=projectPackageName%>/helpers": [
"./src/helpers/index"
],
"<% if (projectName) { %>@<%=projectName%>/<% } %><%=projectPackageName%>": [
"./src/index"
],
"<% if (projectName) { %>@<%=projectName%>/<% } %><%=projectPackageName%>/*": [
"./src/*"
],
"<% if (projectName) { %>@<%=projectName%>/<% } %><%=projectPackageName%>/spec": [
"./src/spec/index"
]
}
"rootDir": "./src"
}
}
20 changes: 1 addition & 19 deletions packages/@ama-sdk/showcase-sdk/tsconfig.build.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,6 @@
"composite": true,
"declaration": true,
"declarationMap": false,
"rootDir": "./src",
"baseUrl": ".",
"paths": {
"@ama-sdk/showcase-sdk/helpers/*": [
"./src/helpers/*"
],
"@ama-sdk/showcase-sdk/helpers": [
"./src/helpers/index"
],
"@ama-sdk/showcase-sdk": [
"./src/index"
],
"@ama-sdk/showcase-sdk/*": [
"./src/*"
],
"@ama-sdk/showcase-sdk/spec": [
"./src/spec/index"
]
}
"rootDir": "./src"
}
}

0 comments on commit e330a46

Please sign in to comment.