fix: pre- and post-handler execution in NanotronApiServer

Co-authored-by: S. Amir Mohammad Najafi <[email protected]>
Alwatr · Oct 16, 2024 · ec3b4b9 · ec3b4b9
1 parent f8efcbf
commit ec3b4b9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/api-server/src/api-server.ts b/packages/api-server/src/api-server.ts
@@ -261,14 +261,14 @@ export class NanotronApiServer {
 
     try {
       for (const handler of routeOption.preHandlers) {
-        if (connection.terminatedHandlers === true) return;
         await handler.call(connection, connection, connection.serverResponse, connection.sharedMeta);
+        if (connection.terminatedHandlers === true) return; // must check after each pre-handler.
       }
 
       await routeOption.handler.call(connection, connection, connection.serverResponse, connection.sharedMeta);
 
       for (const handler of routeOption.postHandlers) {
-        if (connection.terminatedHandlers === true) return;
+        if (connection.terminatedHandlers === true) return; // must check before each post-handler.
         await handler.call(connection, connection, connection.serverResponse, connection.sharedMeta);
       }
     }