Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gitub actions update #18

Closed
wants to merge 5 commits into from
Closed

Fix/gitub actions update #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
76b4a8c
Bump actions/cache from 3 to 4 (#2231)
dependabot[bot] Feb 2, 2024
cff2e98
Bump actions/download-artifact from 3 to 4
dependabot[bot] Feb 1, 2024
fc56769
Bump actions/upload-artifact from 3 to 4
AlvinSchiller Feb 4, 2024
c2d60cb
Bump geekyeggo/delete-artifact from 2 to 4
AlvinSchiller Feb 4, 2024
98f65c9
add write permission for artifact deletion
AlvinSchiller Feb 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- name: Cache Composer packages
id: composer-cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: vendor
key: ${{ runner.os }}-php-${{ hashFiles('**/composer.lock') }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/test_docker_debian.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ jobs:

# Build container and run tests
run:
permissions:
actions: write
name: ${{ matrix.debian_codename }}
strategy:
fail-fast: false
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/test_docker_debian_codename_sub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
BASE_TEST_IMAGE=${{ steps.vars.outputs.image_tag_name_local_base }}

- name: Artifact Upload Docker Image
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ${{ steps.vars.outputs.image_file_name }}
path: ${{ steps.vars.outputs.image_file_path }}
Expand All @@ -150,7 +150,7 @@ jobs:
uses: docker/[email protected]

- name: Artifact Download Docker Image
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: ${{ needs.build.outputs.image_file_name }}

Expand All @@ -170,13 +170,15 @@ jobs:

# cleanup after test execution
cleanup:
permissions:
actions: write
# run only if tests didn't fail: keep the artifact to make job reruns possible
if: ${{ !failure() }}
needs: [build, test]
runs-on: ${{ inputs.runs_on }}

steps:
- name: Artifact Delete Docker Image
uses: geekyeggo/delete-artifact@v2
uses: geekyeggo/delete-artifact@v4
with:
name: ${{ needs.build.outputs.image_file_name }}
Loading