Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to inject service level configurations to DICOM Web STOW and WADO Services #121

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anand-nair
Copy link
Collaborator

The change includes injecting environment variables to STOW and WADO services using config maps.

Signed-off-by: Anand Nair [email protected]

…WADO services

The change includes injecting environment variables to to STOW and WADO services using config maps.
This will allow to override service specific configurations.
The change includes injecting environment variables to STOW and WADO services using config maps. This will allow overriding specific configurations.

Signed-off-by: Anand Nair [email protected]
@jeesmon
Copy link

jeesmon commented Nov 7, 2022

@anand-nair Before I review these changes, can you please create a new issue and describe what is missing from current implementation and what problem you are trying to solve here? In addition to that, in the PR you need to

  • Add appropriate doc updates
  • Unit tests for the change
  • Migration plan as CRD is changing. We need to account for existing installation to make sure it won't break when new change is rolled out.
  • Also plan for publishing a new version of operator to operator hub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants