Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingulmangul
approved these changes
Nov 17, 2023
| for (int i = 0; i < n; i++) { | ||
| cin >> arr[i]; | ||
| } | ||
| cout<<result(n,k,arr); |
There was a problem hiding this comment.
연산 로직을 메인 메소드와 분리해서 구현해주셨네요! 덕분에 코드가 더 깔끔한 것 같아 좋습니다 ^^ 👍
|
|
||
| int result(int n, int k, vector<int>& arr){ | ||
| int left =0, right =0; | ||
| int Max=1; |
There was a problem hiding this comment.
P3. 지역 변수는 소문자로 시작하는게 좋습니다! 상수, 변수, 메소드, 클래스 등을 쉽게 구분하기 위함이니 코드를 작성할 때 네이밍 컨벤션도 고려해 주시면 더 좋을 것 같습니다 :)
Comment on lines
+10
to
+20
| while (left<=right && right < n){ | ||
|
|
||
| if(check[arr[right]]<k){ | ||
| check[arr[right]]++; | ||
| right++; | ||
| Max=max(Max,right-left); | ||
| } else{ | ||
| check[arr[left]]--; | ||
| left++; | ||
| } | ||
| } |
There was a problem hiding this comment.
두 포인터가 각각 어떻게 움직여야 하는지 잘 구현해주신 것 같습니다 !👍
Comment on lines
+21
to
+22
| kind[c]++;//쿠폰 | ||
| cnt++; |
There was a problem hiding this comment.
쿠폰으로 먹은 초밥을 초기화 과정에서 미리 카운팅해주신 점 좋습니다! 이렇게 하면 이후 코드에서 쿠폰 사용을 따로 고려할 필요가 없겠네요
Comment on lines
+35
to
+38
| if(kind[sushi[left++]]==0) cnt--; | ||
| right = (right+1)%n; | ||
| kind[sushi[right]]++; | ||
| if(kind[sushi[right]]==1) cnt++; |
There was a problem hiding this comment.
P3. if문 내에 코드가 한 줄이더라도 중괄호로 감싸주는 게 좋습니다! 이렇게 하면 추후에 코드를 수정할 일이 있을 때 편하고 가독성도 더 좋아요 :)
Comment on lines
+32
to
+40
| while (left<n){ | ||
|
|
||
| kind[sushi[left]]--; | ||
| if(kind[sushi[left++]]==0) cnt--; | ||
| right = (right+1)%n; | ||
| kind[sushi[right]]++; | ||
| if(kind[sushi[right]]==1) cnt++; | ||
| result=max(result,cnt); | ||
| } |
There was a problem hiding this comment.
투포인터를 잘 활용해서 깔끔하게 로직을 세워주신 것 같습니다 🥰👍
|
예린님 안녕하세요! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
인적사항
학번: 2171023
이름: 송예린
과제제출
기존제출: 2473, 2531, 20922
추가제출: